Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/operator-sdk: remove build subcommand #3566

Merged
merged 1 commit into from
Jul 27, 2020

Conversation

estroz
Copy link
Member

@estroz estroz commented Jul 27, 2020

Description of the change: remove the build subcommand

Motivation for the change: make docker-build should be used instead. Relates to #3433.

/cc @fabianvf @joelanford

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@estroz estroz added this to the v1.0.0 milestone Jul 27, 2020
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I think it makes total sense and I think it is no longer required. However, let's double-check with @joelanford is ok with as well because in the past had a motivation to migrate the command to work with the new layout.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2020
@estroz estroz force-pushed the chore/remove-build branch from 34a29a4 to ec29bbc Compare July 27, 2020 16:46
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2020
@estroz estroz force-pushed the chore/remove-build branch from ec29bbc to 93e7eae Compare July 27, 2020 17:07
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2020
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@estroz estroz merged commit 4396ba5 into operator-framework:master Jul 27, 2020
@estroz estroz deleted the chore/remove-build branch July 27, 2020 17:40
@joelanford joelanford mentioned this pull request Jul 27, 2020
92 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants