Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Update remaining v1alpha1 references with v1 #1452

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Nov 13, 2024

Description

There are a few remaining references to v1alpha1 that need to be updated to use v1.

Ref:

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2024
Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 932501a
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/6734a3f047ed190008fdb316
😎 Deploy Preview https://deploy-preview-1452--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@m1kola
Copy link
Member Author

m1kola commented Nov 13, 2024

Blocked by #1451

@m1kola m1kola marked this pull request as ready for review November 13, 2024 11:12
@m1kola m1kola requested a review from a team as a code owner November 13, 2024 11:12
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2024
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2024
There are a few remaining references to v1alpha1 that need to be
updated to use v1.

Ref:
* operator-framework#1228

Signed-off-by: Mikalai Radchuk <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2024
Copy link

openshift-ci bot commented Nov 13, 2024

New changes are detected. LGTM label has been removed.

@m1kola
Copy link
Member Author

m1kola commented Nov 13, 2024

Rebased on top of #1451 so it can pass upgrade-e2e.

@perdasilva perdasilva added this pull request to the merge queue Nov 13, 2024
Merged via the queue into operator-framework:main with commit 102f29f Nov 13, 2024
17 checks passed
@m1kola m1kola deleted the fix_v1alpha1_refs branch November 13, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants