⚠️ Bump ClusterExtension API to v1 #1228

perdasilva · 2024-09-06T15:14:05Z

Description

Updates ClusterExtension to v1
Adds operatorsv1alpha1 package alias for operators/v1alpha1
Does NOT update to catalogd v1 (as that's not merged or released yet)

Reviewer Checklist

API Go Documentation
Tests: Unit Tests (and E2E Tests, if appropriate)
Comprehensive Commit Messages
Links to related GitHub Issue(s)

netlify · 2024-09-06T15:14:22Z

✅ Deploy Preview for olmv1 ready!

Name	Link
🔨 Latest commit	`05f03c6`
🔍 Latest deploy log	https://app.netlify.com/sites/olmv1/deploys/6733bc3c0fbe080008eac482
😎 Deploy Preview	https://deploy-preview-1228--olmv1.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov · 2024-09-06T16:50:06Z

Codecov Report

Attention: Patch coverage is 91.30435% with 6 lines in your changes missing coverage. Please review.

Project coverage is 74.76%. Comparing base (aaa0e00) to head (05f03c6).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/controllers/common_controller.go	82.35%	3 Missing ⚠️
internal/applier/helm.go	75.00%	1 Missing ⚠️
internal/contentmanager/sourcerer.go	0.00%	0 Missing and 1 partial ⚠️
internal/resolve/resolver.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1228      +/-   ##
==========================================
- Coverage   74.88%   74.76%   -0.13%     
==========================================
  Files          42       42              
  Lines        3241     3241              
==========================================
- Hits         2427     2423       -4     
- Misses        643      646       +3     
- Partials      171      172       +1

Flag	Coverage Δ
e2e	`52.05% <81.15%> (ø)`
unit	`57.05% <66.66%> (-0.13%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

perdasilva · 2024-09-06T17:09:45Z

@yashoza19 I just saw that you had your name down on the ticket to bump the API. I was on a bit of rampage today and didn't notice and went ahead and did it. I'm sorry about that. If it's helpful, please take what I've done here, otherwise, I'm happy to close. Apologies again =(

yashoza19 · 2024-09-06T17:14:08Z

@yashoza19 I just saw that you had your name down on the ticket to bump the API. I was on a bit of rampage today and didn't notice and went ahead and did it. I'm sorry about that. If it's helpful, please take what I've done here, otherwise, I'm happy to close. Apologies again =(

@perdasilva No worries at all. I was holding this issue off until we are done with all the other issues in epic-v1.

LalatenduMohanty · 2024-09-09T20:39:01Z

/hold

internal/bundleutil/bundle.go

internal/catalogmetadata/filter/successors.go

internal/catalogmetadata/filter/successors_test.go

internal/contentmanager/cache/cache_test.go

internal/controllers/clusterextension_admission_test.go

internal/controllers/clusterextension_controller.go

internal/controllers/clusterextension_controller_test.go

internal/controllers/common_controller.go

internal/controllers/common_controller_test.go

internal/controllers/suite_test.go

internal/resolve/catalog.go

internal/resolve/catalog_test.go

and other minor version changes that were missed when bumping API versions to v1. Signed-off-by: everettraven <[email protected]>

everettraven · 2024-11-12T20:37:34Z

/hold cancel

The latest release v1.0.0-rc1 includes the change to the API: OLM v1alpha1 APIs became v1 and this needs to be reflected in the upgrade-e2e CI job. Refs: * operator-framework#1228 * operator-framework#1441 Signed-off-by: Mikalai Radchuk <[email protected]>

There are a few remaining references to v1alpha1 that need to be updated to use v1. Ref: * operator-framework#1228 Signed-off-by: Mikalai Radchuk <[email protected]>

The latest release v1.0.0-rc1 includes the change to the API: OLM v1alpha1 APIs became v1 and this needs to be reflected in the upgrade-e2e CI job. Refs: * #1228 * #1441 Signed-off-by: Mikalai Radchuk <[email protected]>

There are a few remaining references to v1alpha1 that need to be updated to use v1. Ref: * operator-framework#1228 Signed-off-by: Mikalai Radchuk <[email protected]>

There are a few remaining references to v1alpha1 that need to be updated to use v1. Ref: * #1228 Signed-off-by: Mikalai Radchuk <[email protected]>

perdasilva requested a review from a team as a code owner September 6, 2024 15:14

perdasilva changed the title ~~⚠️ Bump CatalogExtension API to v1~~ [HOLD] ⚠️ Bump CatalogExtension API to v1 Sep 6, 2024

perdasilva force-pushed the perdasilva/api/bump-to-v1 branch from d847c22 to f5ee8f8 Compare September 6, 2024 16:41

perdasilva force-pushed the perdasilva/api/bump-to-v1 branch from f5ee8f8 to c28a8e4 Compare September 6, 2024 17:01

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 9, 2024

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 11, 2024

perdasilva force-pushed the perdasilva/api/bump-to-v1 branch from c28a8e4 to 99301a4 Compare September 11, 2024 15:00

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 11, 2024

perdasilva force-pushed the perdasilva/api/bump-to-v1 branch from 99301a4 to e75be81 Compare September 11, 2024 15:01

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 12, 2024

perdasilva force-pushed the perdasilva/api/bump-to-v1 branch from e75be81 to 05ac2e2 Compare September 12, 2024 09:40

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 12, 2024

perdasilva marked this pull request as draft September 12, 2024 13:39

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 12, 2024

perdasilva force-pushed the perdasilva/api/bump-to-v1 branch from 05ac2e2 to 39632f2 Compare September 13, 2024 08:49

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2024

perdasilva force-pushed the perdasilva/api/bump-to-v1 branch from 39632f2 to 82c0ef0 Compare September 20, 2024 12:40

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 20, 2024

perdasilva force-pushed the perdasilva/api/bump-to-v1 branch 2 times, most recently from 374f2ce to ccf704f Compare September 25, 2024 15:34

perdasilva changed the title ~~[HOLD] ⚠️ Bump CatalogExtension API to v1~~ [HOLD] ⚠️ Bump ClusterExtension API to v1 Sep 25, 2024

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 28, 2024

perdasilva force-pushed the perdasilva/api/bump-to-v1 branch from ccf704f to 1552e77 Compare October 7, 2024 08:41

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 7, 2024

perdasilva force-pushed the perdasilva/api/bump-to-v1 branch from 1552e77 to e41bc8f Compare October 7, 2024 13:07