Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

option :async is not passed to http sender #167

Merged
merged 2 commits into from
Oct 25, 2019
Merged

option :async is not passed to http sender #167

merged 2 commits into from
Oct 25, 2019

Conversation

turnon
Copy link
Contributor

@turnon turnon commented Oct 21, 2019

v0.37.0 said it added an async option to the HTTP and SQS senders, but in fact only added to SQS. This PR fix it.

jfeltesse-mdsol
jfeltesse-mdsol reviewed Oct 21, 2019
View reviewed changes
lib/zipkin-tracer/tracer_factory.rb
options = { json_api_host: config.json_api_host, logger: config.logger }
options = {
json_api_host: config.json_api_host,
async: config.async,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you puts async first so the order is alphabetical (like the SQS sender)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

jfeltesse-mdsol
jfeltesse-mdsol reviewed Oct 21, 2019
View reviewed changes
Copy link
Contributor

@jfeltesse-mdsol jfeltesse-mdsol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't remember so much the code but would it be easy to add specs to ensure that switch case statement passes the expected options to the correct initializer?

@turnon turnon force-pushed the fix_async_http_sender branch from 299eff3 to dd38985 Compare October 21, 2019 15:23
@turnon
Copy link
Contributor Author

turnon commented Oct 21, 2019

Don't remember so much the code but would it be easy to add specs to ensure that switch case statement passes the expected options to the correct initializer?

specs added

@jcarres-mdsol jcarres-mdsol merged commit 79c9980 into openzipkin:master Oct 25, 2019
@jcarres-mdsol
Copy link
Collaborator

Thanks!

@turnon turnon deleted the fix_async_http_sender branch October 25, 2019 07:24
@jfeltesse-mdsol jfeltesse-mdsol mentioned this pull request Oct 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfeltesse-mdsol jfeltesse-mdsol jfeltesse-mdsol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@turnon @jcarres-mdsol @jfeltesse-mdsol