Add support for writing B3 single header #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| expect(request_headers['X-B3-SpanId']).to match(HEX_REGEX) | ||
| expect(request_headers['X-B3-Sampled']).to eq('true') | ||
| expect(request_headers['X-B3-Flags']).to eq('1') | ||
| expect(request_headers['B3']).to match(/\A0000000000000001-\h{16}-d-0000000000000003\z/) |
There was a problem hiding this comment.
please downcase this by default.
There was a problem hiding this comment.
updated in 00f824b
codefromthecrypt
approved these changes
Oct 16, 2019
|
can you squash the commits in your fork so the history doesn't feature those extra commits related to syncing with upstream? |
|
Rebased on the top of |
| * Omit ParentSpanId header for root spans. | ||
|
|
||
| # 0.40.1 | ||
| * Fix to pass `async` option to the HTTP sender. |
There was a problem hiding this comment.
sorry for not picking this up in #167 and thanks for adding it 🙇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to support the "writing" part of B3 single header (#126)
Also, fixes #115
@adriancole @jcarres-mdsol @jfeltesse-mdsol