Always use build kit on deploy #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using Docker 20.10 commands we used before now break like this: ``` image with reference sha256:6deb7d92f59f205ddaf95230bec403fd117ab8f509074f09a3fc6b108276d744 was found but does not match the specified platform: wanted linux/arm64, actual: linux/amd64 ``` This switches to always use BUILDKIT=1 when pushing images, as Docker changed behavior in 20.10 and it is more complex to figure out if we are 20.10 or not, and would be annoying to figure out what later versions would do. See moby/moby#41552
anuraaga
approved these changes
Dec 17, 2020
codefromthecrypt
pushed a commit
that referenced
this pull request
Dec 17, 2020
In #11, I tried to find a configuration that works both in Docker 19 and 20. However, this breaks the build. This reverts the change as there are bugs popping up related on Docker 20 anyway, such as docker/buildx#475 We use Docker from the OS distribution, so unlikely to accidentally walk into a Docker 20. In other words, when it becomes stable, we can try again.
|
This didn't work, so reverted it until things in Docker 20 stabalize, ideally to the point it is possible to use the same syntax for both 19 and 20 31b4d18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Docker 20.10 commands we used before now break like this:
This switches to always use BUILDKIT=1 when pushing images, as Docker
changed behavior in 20.10 and it is more complex to figure out if we are
20.10 or not, and would be annoying to figure out what later versions
would do.
See moby/moby#41552