driver: do not insert "platform" as driver-opt #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiborvass
force-pushed
the
fix_create_platform_regression
branch
from
5aeca47 to
c994b94
Compare
Addresses docker/setup-buildx-action#45 Simple repro: ``` $ buildx create --platform linux/amd64 --use $ buildx build - <<EOF from scratch EOF ``` Since docker#370 a `platform` driver-opt was automatically inserted with the value specified by `--platform` flag on regardless of the type of driver, even though it was only used in the kubernetes driver. However, because the docker-container driver is pedantic about the options being passed, it errored out. Another side-effect I suspect is that with the kubernetes driver it was now possible to specify the platforms in two different ways: `--driver-opt platform=...` and `--platform`. This patch reverts completely the `platform` driver-opt and instead ensures the platforms information is passed onto the kubernetes driver via variables. Signed-off-by: Tibor Vass <[email protected]>
tiborvass
force-pushed
the
fix_create_platform_regression
branch
from
c994b94 to
381dc8f
Compare
|
LGTM |
|
This pr works well. with kubernetes driver |
tiborvass
approved these changes
Dec 15, 2020
codefromthecrypt
pushed a commit
to openzipkin/docker-alpine
that referenced
this pull request
Dec 17, 2020
In #11, I tried to find a configuration that works both in Docker 19 and 20. However, this breaks the build. This reverts the change as there are bugs popping up related on Docker 20 anyway, such as docker/buildx#475 We use Docker from the OS distribution, so unlikely to accidentally walk into a Docker 20. In other words, when it becomes stable, we can try again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses docker/setup-buildx-action#45
Simple repro:
Since #370 a
platformdriver-opt was automatically inserted with the value specified by--platformflag on regardless of the type of driver, even though it was only used in the kubernetes driver. However, because the docker-container driver is pedantic about the options being passed, it errored out.Another side-effect I suspect is that with the kubernetes driver it was now possible to specify the platforms in two different ways:
--driver-opt platform=...and--platform.This patch reverts completely the
platformdriver-opt and instead ensures the platforms information is passed onto the kubernetes driver via variables.Signed-off-by: Tibor Vass [email protected]
cc @morlay