Removes bytecode so we can add more #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI this is in support of #557 (firehose mode) which I have some work in progress on. First steps are to make room for code. |
This removes the auto-value dependency and related for inlining the few cases where it was used. It also trims the class hierarchy of sampling flags. Finally, it moves out the in-flight localEndpoint as it is constant. Besides fixing a few bugs, these changes reduced the size of the jar by 12KiB and scraps 2 dependencies. ```bash du -k /Users/acole/.m2/repository/io/zipkin/brave/brave/5.1.2/brave-5.1.2.jar /Users/acole/.m2/repository/io/zipkin/brave/brave/5.1.3-SNAPSHOT/brave-5.1.3-SNAPSHOT.jar 116 /Users/acole/.m2/repository/io/zipkin/brave/brave/5.1.2/brave-5.1.2.jar 128 /Users/acole/.m2/repository/io/zipkin/brave/brave/5.1.3-SNAPSHOT/brave-5.1.3-SNAPSHOT.jar ```
codefromthecrypt
force-pushed
the
bytecode-smaller
branch
from
fed9d28 to
5733475
Compare
| public static final SamplingFlags EMPTY = new SamplingFlagsImpl(null, false); | ||
| public static final SamplingFlags SAMPLED = new SamplingFlagsImpl(true, false); | ||
| public static final SamplingFlags NOT_SAMPLED = new SamplingFlagsImpl(false, false); | ||
| public static final SamplingFlags DEBUG = new SamplingFlagsImpl(true, true); |
There was a problem hiding this comment.
intellij showed warnings about classloader deadlock by referencing a subclass ctor in a super. the changes here not only make things smaller, but also remove that possibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the auto-value dependency and related for inlining the few
cases where it was used. It also trims the class hierarchy of sampling
flags. Finally, it moves out the in-flight localEndpoint as it is
constant.
Besides fixing a few bugs, these changes reduced the size of the jar by
12KiB and scraps 2 dependencies.