Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support "firehose mode" #557

Closed
codefromthecrypt opened this issue Dec 18, 2017 · 3 comments
Closed

Support "firehose mode" #557

codefromthecrypt opened this issue Dec 18, 2017 · 3 comments

Comments

@codefromthecrypt
Copy link
Member

Full description pending, but this will describe a mode where brave collects data regardless of sampling decision. At the point where spanReporter is used today, a branch will occur where "firehose" reporter gets all spans, and the existing one, only sampled ones. This is in support of aggregators such as span metrics.

Coming out of #529
@codefromthecrypt codefromthecrypt mentioned this issue Dec 18, 2017
Closed
This was referenced Jul 21, 2018
Merged
Closed
Merged
codefromthecrypt pushed a commit that referenced this issue Aug 1, 2018
Renames SpanRecord back to MutableSpan
ea1f5b6 
Performance is great, but implications of mutability should be
top-level. This renames SpanRecord back to MutableSpan, as it
focuses on the important thing.

See #557
@codefromthecrypt codefromthecrypt mentioned this issue Aug 1, 2018
Merged
codefromthecrypt pushed a commit that referenced this issue Aug 1, 2018
@adriancole
Renames SpanRecord back to MutableSpan
3774c2c 
Performance is great, but implications of mutability should be
top-level. This renames SpanRecord back to MutableSpan, as it
focuses on the important thing.

See #557
@codefromthecrypt codefromthecrypt mentioned this issue Aug 2, 2018
Closed
@codefromthecrypt
Copy link
Member Author

(TraceContext, MutableSpan) will be the primary input for firehose handlers, whether they are metrics or service aggregators, or a secondary zipkin instance.

There will be another flag that will determine if we record regardless of the primary sampling status. Stay tuned.

@codefromthecrypt codefromthecrypt mentioned this issue Aug 22, 2018
Closed
@codefromthecrypt codefromthecrypt mentioned this issue Sep 20, 2018
Merged
@codefromthecrypt
Copy link
Member Author

finally got focus time on firehose #791

@codefromthecrypt
Copy link
Member Author

#796 < README

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@codefromthecrypt