Refactors build to use a parent pom #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: I initially planned to use properties files, but mojohaus/properties-maven-plugin#26 thwarted me. This centralizes all the build config into maven pom rather than splitting into multiple locations. |
codefromthecrypt
changed the title
codefromthecrypt
force-pushed
the
parent
branch
from
3bf0225
to
7f79bb6
Compare
codefromthecrypt
force-pushed
the
parent
branch
from
8653c03
to
ed1c9b7
Compare
anuraaga
approved these changes
Oct 9, 2020
codefromthecrypt
commented
Oct 9, 2020
This simplifies the build a lot by using a parent pom (as suggested by @trustin) This simplifies further by moving some configuration managementt to `build_image`.
codefromthecrypt
force-pushed
the
parent
branch
from
2fad53f
to
b0c49cb
Compare
|
fingers crossed syntax is correct for both dockerhub and GH actions now :D sorry about the thrash, I should have pushed a branch before making a PR out of it. |
|
finally green! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the build a lot by using a parent pom (as suggested by @trustin)
This simplifies further by moving some configuration management to
build_image.