Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample code for Spring 2.X is not working since Spring Rest Template is not available in Spring 2.X #21

Closed
garymabin opened this issue Nov 28, 2017 · 5 comments
Closed

Sample code for Spring 2.X is not working since Spring Rest Template is not available in Spring 2.X #21

garymabin opened this issue Nov 28, 2017 · 5 comments

Comments

@garymabin
Copy link

Spring Rest Template is not available until Spring3. While in the sample code brave-instrument-spring-web is dependent on Spring Rest Template, more specifically is TracingClientHttpRequestIntercepter depends on ClientHttpRequestInterceptor
@codefromthecrypt
Copy link
Member

codefromthecrypt commented Nov 28, 2017 via email

@garymabin
Copy link
Author

garymabin commented Nov 28, 2017 •
edited
Loading

Haven't spent much time on the investigation, it seems spring rest template is quite independent, so my solution is just copy spring rest template from Spring 3+ and makes it a private library. Probably what is needed here is to give some instructions for those who want to trace their Spring 2.X application.

@codefromthecrypt
Copy link
Member

openzipkin/zipkin-reporter-java#83 is the first part of getting spring 2.x working

codefromthecrypt pushed a commit to openzipkin/brave that referenced this issue Dec 12, 2017
Makes brave-spring-beans Spring 2.5 compatible
5c51589 
See openzipkin/brave-example#21
@codefromthecrypt codefromthecrypt mentioned this issue Dec 12, 2017
Merged
codefromthecrypt pushed a commit to openzipkin/brave that referenced this issue Dec 13, 2017
Makes brave-spring-beans Spring 2.5 compatible
4571aaa 
See openzipkin/brave-example#21
@codefromthecrypt
Copy link
Member

#22 is awaiting a brave release

codefromthecrypt pushed a commit to openzipkin/brave that referenced this issue Dec 13, 2017
@adriancole
Makes brave-spring-beans Spring 2.5 compatible
47eb60c 
See openzipkin/brave-example#21
@codefromthecrypt
Copy link
Member

ok try it out now and re-open if needed!

codefromthecrypt pushed a commit that referenced this issue Oct 8, 2020
@ikhoon
Upgrade Armeria to 0.99.7 (#21)
1c538d5
thgoexpt added a commit to thgoexpt/Java-distributed-tracing-implementation that referenced this issue Apr 7, 2022
@thgoexpt
Makes brave-spring-beans Spring 2.5 compatible
adf923e 
See openzipkin/brave-example#21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@codefromthecrypt @garymabin