Adds spring beans XML config for legacy applications #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the ability to configure all properties for senders, notably Kafka topic. Fixes openzipkin/brave-example#19
codefromthecrypt
force-pushed
the
spring-beans
branch
from
6a4b372 to
45ad395
Compare
|
This codebase can be used by any library, not just Brave. However, Brave will continue this effort, re-jigging its XML config support to Spring 2.x (from 3.x), using this so you can configure details like the kafka topic name openzipkin/brave#549 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to configure all properties for senders,
notably Kafka topic.
Fixes openzipkin/brave-example#19