Factor Linux specific functionality out of libzutil

[mattmacy]

Signed-off-by: Matt Macy [email protected]

Motivation and Context

Description

How Has This Been Tested?

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Performance enhancement (non-breaking change which improves efficiency)
• Code cleanup (non-breaking change which makes code smaller or more readable)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation (a change to man pages or other documentation)

Checklist:

• My code follows the ZFS on Linux code style requirements.
• I have updated the documentation accordingly.
• I have read the contributing document.
• I have added tests to cover my changes.
• All new and existing tests passed.
• All commit messages are properly formatted and contain Signed-off-by.

[ghost]

I think we can do a better job sharing code here, we're going to have another look.

[behlendorf]

cc: @don-brady

[behlendorf]

On FreeBSD is there an blkid equivalent which can be used here? Or will only the scan and cache options be implemented?

[ghost]

There may be a possibility of using libblkid (I see a port for it anyway) but what I anticipate will end up here on FreeBSD is the code we have to scan our GEOM tree.

[ghost]

• Move Linux specific functions from zutil_device_path.c to os/linux/zutil_device_path_os.c.
• Use boolean_t as return type for zfs_dev_is_* predicates and adjust the caller accordingly. This matches the comment at the top of one of the functions; the other function's comment was updated to match.
• Share definition of struct libpc_handle with os specific implementation to remove #ifdef notyet.
• Provide real definitions for some functions when building without libudev.
• Make zutil_import.h include consistent.

[ghost]

• Add missing includes to os/linux/zutil_device_path_os.c.

[behlendorf]

Looks good. Let's just address the zfs_verror nit, and then we can plan to merge this tomorrow.

[ghost]

• zfs_verror -> zutil_verror

[behlendorf]

Thanks, looks good. Can you just rebase this to resole the conflict due to some other recent merges.

[ghost]

^^ Rebase
^ Remove leftover devid.h include

[codecov]

Codecov Report

Merging #9356 into master will increase coverage by 12.48%.
The diff coverage is 75%.

@@             Coverage Diff             @@
##           master    #9356       +/-   ##
===========================================
+ Coverage   66.62%    79.1%   +12.48%     
===========================================
  Files         326      406       +80     
  Lines      105097   122527    +17430     
===========================================
+ Hits        70017    96925    +26908     
+ Misses      35080    25602     -9478

Flag	Coverage Δ
#kernel	79.79% <ø> (?)
#user	66.83% <75%> (+0.21%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ae8b2a...831b0f9. Read the comment docs.