Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenZFS refactor - factor platform specific bits out of libzfs #9377

Merged
merged 1 commit into from
Oct 3, 2019

Conversation

mattmacy
Copy link
Contributor

@mattmacy mattmacy commented Sep 29, 2019

Signed-off-by: Matthew Macy [email protected]

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

Copy link
Contributor

@allanjude allanjude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed By: [email protected]

@lundman
Copy link
Contributor

lundman commented Sep 29, 2019

Out of curiosity, what platforms use LIBFETCH right now? OsX is still on the original OpenSSL version of the source, which I think ZOL changed away from, due to licenses, do both fbsd and zol use libfetch?

@mattmacy
Copy link
Contributor Author

Out of curiosity, what platforms use LIBFETCH right now? OsX is still on the original OpenSSL version of the source, which I think ZOL changed away from, due to licenses, do both fbsd and zol use libfetch?
I only know of FreeBSD using it.

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Sep 30, 2019
@mattmacy mattmacy force-pushed the project/libzfs_refactor branch from 1815184 to b5540f7 Compare September 30, 2019 19:48
@mattmacy mattmacy force-pushed the project/libzfs_refactor branch from b5540f7 to e01fb8e Compare October 2, 2019 21:40
@mattmacy
Copy link
Contributor Author

mattmacy commented Oct 2, 2019

Out of curiosity, what platforms use LIBFETCH right now? OsX is still on the original OpenSSL version of the source, which I think ZOL changed away from, due to licenses, do both fbsd and zol use libfetch?

I'm reverting that change. We're going to import libfetch for platforms that don't have it included as part of a separate PR.

@mattmacy mattmacy force-pushed the project/libzfs_refactor branch from e01fb8e to 5d885a1 Compare October 3, 2019 00:03
@codecov
Copy link

codecov bot commented Oct 3, 2019

Codecov Report

Merging #9377 into master will increase coverage by 12.53%.
The diff coverage is 65.21%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #9377       +/-   ##
===========================================
+ Coverage   66.62%   79.15%   +12.53%     
===========================================
  Files         326      408       +82     
  Lines      105097   122533    +17436     
===========================================
+ Hits        70017    96992    +26975     
+ Misses      35080    25541     -9539
Flag Coverage Δ
#kernel 79.74% <ø> (?)
#user 66.84% <65.21%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ae8b2a...5d885a1. Read the comment docs.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Oct 3, 2019
@behlendorf behlendorf merged commit 73cdcc6 into openzfs:master Oct 3, 2019
@mattmacy mattmacy deleted the project/libzfs_refactor branch December 19, 2019 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants