OpenZFS 9426 - metaslab size can exceed offset addressable by spacemap #7700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Authored by: Don Brady <[email protected]> Reviewed by: Paul Dagnelie <[email protected]> Reviewed by: Matt Ahrens <[email protected]> Ported-by: Brian Behlendorf <[email protected]> Approved by: Dan McDonald <[email protected]> OpenZFS-issue: https://www.illumos.org/issues/9426 OpenZFS-commit: openzfs/openzfs@f1c88afb1
Codecov Report
@@ Coverage Diff @@
## master #7700 +/- ##
==========================================
+ Coverage 78.11% 78.17% +0.05%
==========================================
Files 368 368
Lines 111830 111834 +4
==========================================
+ Hits 87354 87424 +70
+ Misses 24476 24410 -66
Continue to review full report at Codecov.
|
gmelikov
reviewed
Jul 11, 2018
| @@ -52,15 +52,21 @@ | |||
| #include <sys/zvol.h> | |||
| #include <sys/zfs_ratelimit.h> | |||
|
|
|||
| /* maximum number of metaslabs per top-level vdev */ | |||
| /* target number of metaslabs per top-level vdev */ | |||
| int vdev_max_ms_count = 200; | |||
There was a problem hiding this comment.
Maybe we should rename it to vdev_target_ms_count?
There was a problem hiding this comment.
I had the same thought, but in the end decided against it since we want to keep this consistent across implementations. Plus it's unlikely users would ever need to tune this, it's primarily made available for developers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Metaslab size can exceed offset addressable by spacemap
Motivation and Context
OpenZFS-issue: https://www.illumos.org/issues/9426
OpenZFS-commit: openzfs/openzfs@f1c88afb1
How Has This Been Tested?
Locally built.
Types of changes
Checklist:
Signed-off-by.