Don't count '@' for dataset namelen if not a snapshot #5456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix pool unimportable when dataset namelen is 255 Signed-off-by: Chunwei Chen <[email protected]> Fix openzfs#5432
|
@tuxoko, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ikozhukhov, @ahrens and @behlendorf to be potential reviewers. |
dinatale2
suggested changes
Dec 5, 2016
behlendorf
requested changes
Dec 5, 2016
behlendorf
approved these changes
Dec 6, 2016
|
http://build.zfsonlinux.org/builders/CentOS%207.1%20x86_64%20%28TEST%29/builds/3758/steps/shell_11/logs/stdio |
|
Usually this is due to the test case mode bits. Make sure it's executable. |
|
Oh, I forgot add it to Makefile.am |
Signed-off-by: Chunwei Chen <[email protected]>
dinatale2
approved these changes
Dec 6, 2016
ironMann
pushed a commit
to ironMann/zfs
that referenced
this pull request
Dec 13, 2016
Don't count '@' for dataset namelen if not a snapshot. This fixes making a pool unimportable when the dataset namelen is 255. Add test file for zfs create name length 255. Reviewed-by: Giuseppe Di Natale <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Chunwei Chen <[email protected]> Closes openzfs#5432 Closes openzfs#5456
behlendorf
pushed a commit
to behlendorf/zfs
that referenced
this pull request
Feb 2, 2017
Don't count '@' for dataset namelen if not a snapshot. This fixes making a pool unimportable when the dataset namelen is 255. Add test file for zfs create name length 255. Reviewed-by: Giuseppe Di Natale <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Chunwei Chen <[email protected]> Closes openzfs#5432 Closes openzfs#5456
behlendorf
pushed a commit
to behlendorf/zfs
that referenced
this pull request
Feb 2, 2017
Don't count '@' for dataset namelen if not a snapshot. This fixes making a pool unimportable when the dataset namelen is 255. Add test file for zfs create name length 255. Reviewed-by: Giuseppe Di Natale <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Chunwei Chen <[email protected]> Closes openzfs#5432 Closes openzfs#5456 Requires-builders: style
behlendorf
pushed a commit
that referenced
this pull request
Feb 3, 2017
Don't count '@' for dataset namelen if not a snapshot. This fixes making a pool unimportable when the dataset namelen is 255. Add test file for zfs create name length 255. Reviewed-by: Giuseppe Di Natale <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Chunwei Chen <[email protected]> Closes #5432 Closes #5456
wli5
pushed a commit
to wli5/zfs
that referenced
this pull request
Feb 28, 2017
Don't count '@' for dataset namelen if not a snapshot. This fixes making a pool unimportable when the dataset namelen is 255. Add test file for zfs create name length 255. Reviewed-by: Giuseppe Di Natale <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Chunwei Chen <[email protected]> Closes openzfs#5432 Closes openzfs#5456
wli5
pushed a commit
to wli5/zfs
that referenced
this pull request
Feb 28, 2017
Don't count '@' for dataset namelen if not a snapshot. This fixes making a pool unimportable when the dataset namelen is 255. Add test file for zfs create name length 255. Reviewed-by: Giuseppe Di Natale <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Chunwei Chen <[email protected]> Closes openzfs#5432 Closes openzfs#5456
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix pool unimportable when dataset namelen is 255
Signed-off-by: Chunwei Chen [email protected]
Fix #5432