Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a dataset with name length 255 cause pool unimportable #5432

Closed
tuxoko opened this issue Nov 30, 2016 · 0 comments · Fixed by #5456
Closed

Create a dataset with name length 255 cause pool unimportable #5432

tuxoko opened this issue Nov 30, 2016 · 0 comments · Fixed by #5456
Milestone
0.7.0

Comments

@tuxoko
Copy link
Contributor

tuxoko commented Nov 30, 2016 •
edited
Loading

This is tested on zfs-0.6.5.8

zfs create dataset with name lengh 255 returns success. However the pool becomes unimportable.

$ sudo zfs create pp/012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901
$ sudo zpool export pp
$ sudo zpool import pp
cannot import 'pp': new name of at least one dataset is longer than the maximum allowable length

BTW, try creating dataset name len >= 256 will fail as expected. This only happens when len == 255.
@behlendorf behlendorf added this to the 0.7.0 milestone Nov 30, 2016
tuxoko pushed a commit to tuxoko/zfs that referenced this issue Dec 3, 2016
Don't count '@' for dataset namelen if not a snapshot
eacd2b0 
Signed-off-by: Chunwei Chen <[email protected]>
Fix openzfs#5432
tuxoko pushed a commit to tuxoko/zfs that referenced this issue Dec 5, 2016
Don't count '@' for dataset namelen if not a snapshot
ea7bd26 
This fix pool unimportable when dataset namelen is 255

Signed-off-by: Chunwei Chen <[email protected]>
Fix openzfs#5432
@tuxoko tuxoko mentioned this issue Dec 5, 2016
Merged
behlendorf pushed a commit that referenced this issue Dec 9, 2016
@tuxoko @behlendorf
Don't count '@' for dataset namelen if not a snapshot
a806cb6 
Don't count '@' for dataset namelen if not a snapshot.  This
fixes making a pool unimportable when the  dataset namelen
is 255.

Add test file for zfs create name length 255.

Reviewed-by: Giuseppe Di Natale <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Chunwei Chen <[email protected]>
Closes #5432 
Closes #5456
ironMann pushed a commit to ironMann/zfs that referenced this issue Dec 13, 2016
@tuxoko @ironMann
Don't count '@' for dataset namelen if not a snapshot
f070522 
Don't count '@' for dataset namelen if not a snapshot.  This
fixes making a pool unimportable when the  dataset namelen
is 255.

Add test file for zfs create name length 255.

Reviewed-by: Giuseppe Di Natale <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Chunwei Chen <[email protected]>
Closes openzfs#5432 
Closes openzfs#5456
behlendorf pushed a commit to behlendorf/zfs that referenced this issue Feb 2, 2017
@tuxoko @behlendorf
Don't count '@' for dataset namelen if not a snapshot
3fbcb47 
Don't count '@' for dataset namelen if not a snapshot.  This
fixes making a pool unimportable when the  dataset namelen
is 255.

Add test file for zfs create name length 255.

Reviewed-by: Giuseppe Di Natale <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Chunwei Chen <[email protected]>
Closes openzfs#5432 
Closes openzfs#5456
behlendorf pushed a commit to behlendorf/zfs that referenced this issue Feb 2, 2017
@tuxoko @behlendorf
Don't count '@' for dataset namelen if not a snapshot
a003e40 
Don't count '@' for dataset namelen if not a snapshot.  This
fixes making a pool unimportable when the  dataset namelen
is 255.

Add test file for zfs create name length 255.

Reviewed-by: Giuseppe Di Natale <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Chunwei Chen <[email protected]>
Closes openzfs#5432
Closes openzfs#5456
Requires-builders: style
behlendorf pushed a commit that referenced this issue Feb 3, 2017
@tuxoko @behlendorf
Don't count '@' for dataset namelen if not a snapshot
f3da7a1 
Don't count '@' for dataset namelen if not a snapshot.  This
fixes making a pool unimportable when the  dataset namelen
is 255.

Add test file for zfs create name length 255.

Reviewed-by: Giuseppe Di Natale <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Chunwei Chen <[email protected]>
Closes #5432
Closes #5456
wli5 pushed a commit to wli5/zfs that referenced this issue Feb 28, 2017
@tuxoko @wli5
Don't count '@' for dataset namelen if not a snapshot
97f0d01 
Don't count '@' for dataset namelen if not a snapshot.  This
fixes making a pool unimportable when the  dataset namelen
is 255.

Add test file for zfs create name length 255.

Reviewed-by: Giuseppe Di Natale <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Chunwei Chen <[email protected]>
Closes openzfs#5432 
Closes openzfs#5456
wli5 pushed a commit to wli5/zfs that referenced this issue Feb 28, 2017
@tuxoko @wli5
Don't count '@' for dataset namelen if not a snapshot
3a119eb 
Don't count '@' for dataset namelen if not a snapshot.  This
fixes making a pool unimportable when the  dataset namelen
is 255.

Add test file for zfs create name length 255.

Reviewed-by: Giuseppe Di Natale <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Chunwei Chen <[email protected]>
Closes openzfs#5432
Closes openzfs#5456
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.0
Development

Successfully merging a pull request may close this issue.

Don't count '@' for dataset namelen if not a snapshot tuxoko/zfs
2 participants
@tuxoko @behlendorf