Linux 4.9 compat #5307
Merged
Linux 4.9 compat #5307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tuxoko, thanks for your PR! By analyzing the history of the files in this pull request, we identified @behlendorf, @maxximino and @ryao to be potential reviewers. |
added 3 commits
October 19, 2016 11:46
These operations are dir specific, there's no point putting them in zpl_inode_operations which is for regular files. Signed-off-by: Chunwei Chen <[email protected]>
In Linux 4.9, torvalds/linux@2773bf0, iops->rename() and iops->rename2() are merged together into iops->rename(), it now wants flags. Signed-off-by: Chunwei Chen <[email protected]>
In Linux 4.9, torvalds/linux@fd50eca, iops->{set,get,remove}xattr and generic_{set,get,remove}xattr are removed. xattr operations will directly go through sb->s_xattr. Signed-off-by: Chunwei Chen <[email protected]>
tuxoko
force-pushed
the
linux4.9
branch
2 times, most recently
from
854a364 to
1bc248b
Compare
behlendorf
requested changes
Oct 19, 2016
| ],[ | ||
| AC_MSG_RESULT(no) | ||
| ]) | ||
| ]) |
There was a problem hiding this comment.
Let's steal my configure check, 3d8c8e8, for this since it also verifies the argument types to setattr_prepare which means if they change we'll notice immediately.
Closed
In torvalds/linux@31051c8 the inode_change_ok() function was renamed setattr_prepare() and updated to take a dentry ratheri than an inode. Update the code to call the setattr_prepare() and add a wrapper function which call inode_change_ok() for older kernels. Signed-off-by: Brian Behlendorf <[email protected]> Signed-off-by: Chunwei Chen <[email protected]> Requires-spl: refs/pull/581/head
|
@tuxoko were you able to boot a 4.9 kernel and test these changes? |
behlendorf
approved these changes
Oct 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly the same with #5301.
The difference:
The "Remove dir inode operations from zpl_inode_operations" removes the inode operations that should not belong to regular file.
The "rename" patch, I tried to not mangle with the function prototype.