Linux 4.9 compat #5301
Closed
Linux 4.9 compat #5301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The iops->rename() callback has been replaced by iops->rename2() which was introduced in an earlier kernel release. Until such time as we support the additional flags it's safe to simply return -EINVAL when any flags are passed. Signed-off-by: Brian Behlendorf <[email protected]>
In torvalds/linux@31051c8 the inode_change_ok() function was renamed setattr_prepare() and updated to take a dentry ratheri than an inode. Update the code to call the setattr_prepare() and add a wrapper function which call inode_change_ok() for older kernels. Signed-off-by: Brian Behlendorf <[email protected]>
Commit torvalds/linux@6c6ef9f removes the getxattr, setxattr, and removexattr callbacks. All filesystems which support xattrs are required to have registered them with sb->s_xattr. The ZFS code made this change already so the only required change is to not register the callback in the inode_operations structure. Signed-off-by: Brian Behlendorf <[email protected]> Requires-spl: refs/pull/580/head
|
@behlendorf, thanks for your PR! By analyzing the history of the files in this pull request, we identified @maxximino, @tuxoko and @dechamps to be potential reviewers. |
behlendorf
added
the
Type: Building
|
@behlendorf Uhh, I was doing this today... |
|
That's OK, we'll take the best bits of each implementation. Plus it'll make it easier to review. |
Merged
|
Closing is favor of #5307 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes required to update ZFS to be compatible with the unreleased 4.9
kernel. These changes have been compile tested but the ZFS Test Suite
has not been run on a 4.9-rc1+ kernel.
Linux 4.9 compat: iops->*xattr removed
Linux 4.9 compat: inode_change_ok() renamed setattr_prepare()
Linux 4.9 compat: rename2() -> rename()