[master re-sync of #2479, buildbot] zvol create minors check snapdev before traversing snapshots #3663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm starting to use snapshots more and more, thus this would be good to have, [also I'm currently updating the system kernel so taking a look at what needs to be changed with ZFS, too] |
kernelOfTruth
changed the title
kernelOfTruth
changed the title
|
@kernelOfTruth of truth could you fix the style issues in these patches and force update the patch stack. I agree, this or something like this would be good to have merged. |
kernelOfTruth
force-pushed
the
zfs_master_30.07.2015_2479-zvol_create_minors-check-snapdev-before-traversing-snapshots_2
branch
from
f04207d to
89d5a97
Compare
References: openzfs#2479 openzfs@79c76d5 (Change KM_PUSHPAGE -> KM_SLEEP) Porting notes: @@ __zvol_create_minor(const char *name, boolean_t ignore_snapdev) [which got changed to] @@ __zvol_create_minor(const char *name) doi = kmem_alloc(sizeof (dmu_object_info_t), KM_PUSHPAGE); [replaced with] doi = kmem_alloc(sizeof (dmu_object_info_t), KM_SLEEP); Caused by 79c76d5 Change KM_PUSHPAGE -> KM_SLEEP (upstream sync). Fixing cstyle error: "unparenthesized return expression" message in linux 1509
kernelOfTruth
force-pushed
the
zfs_master_30.07.2015_2479-zvol_create_minors-check-snapdev-before-traversing-snapshots_2
branch
from
89d5a97 to
54bbab4
Compare
References: openzfs#2479 openzfs@79c76d5 (Change KM_PUSHPAGE -> KM_SLEEP) @@ __zvol_create_minor(const char *name) doi = kmem_alloc(sizeof (dmu_object_info_t), KM_PUSHPAGE); [replaced with] doi = kmem_alloc(sizeof (dmu_object_info_t), KM_SLEEP); Caused by 79c76d5 Change KM_PUSHPAGE -> KM_SLEEP (upstream sync). Fixing cstyle errors: space or tab at end of line indent by spaces instead of tabs missing space between keyword and paren unparenthesized return expression
kernelOfTruth
force-pushed
the
zfs_master_30.07.2015_2479-zvol_create_minors-check-snapdev-before-traversing-snapshots_2
branch
from
54bbab4 to
3c1758e
Compare
|
@behlendorf done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2479 (zvol_create_minors(): check snapdev before traversing snapshots #2479)
also related to #2388