Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zvol_create_minors(): check snapdev before traversing snapshots #2479

Closed
wants to merge 1 commit into from
Closed

zvol_create_minors(): check snapdev before traversing snapshots #2479

wants to merge 1 commit into from

Conversation

bprotopopov
Copy link
Contributor

This is to address issue #2217 scalability issues with zvol_create_minors(pool). The pull request has been re-submitted without changes following local (forked) repo reorg.

@bprotopopov bprotopopov mentioned this pull request Jul 10, 2014
Closed
FransUrbo pushed a commit to FransUrbo/zfs that referenced this pull request Aug 19, 2014
@bprotopopov @FransUrbo
=> openzfs#2479: bprotopopov/zvol-scale - zvol_create_minors(): check…
def2dce 
… snapdev before traversing snapshots
FransUrbo pushed a commit to FransUrbo/zfs that referenced this pull request Aug 21, 2014
@bprotopopov @FransUrbo
=> openzfs#2479: bprotopopov/zvol-scale - zvol_create_minors(): check…
5d46b0a 
… snapdev before traversing snapshots
FransUrbo pushed a commit to FransUrbo/zfs that referenced this pull request Aug 29, 2014
@bprotopopov @FransUrbo
=> openzfs#2479: bprotopopov/zvol-scale - zvol_create_minors(): check…
386c32f 
… snapdev before traversing snapshots
FransUrbo pushed a commit to FransUrbo/zfs that referenced this pull request Sep 5, 2014
@bprotopopov @FransUrbo
=> openzfs#2479: bprotopopov/zvol-scale - zvol_create_minors(): check…
9f88847 
… snapdev before traversing snapshots
FransUrbo pushed a commit to FransUrbo/zfs that referenced this pull request Sep 5, 2014
@bprotopopov @FransUrbo
=> openzfs#2479: bprotopopov/zvol-scale - zvol_create_minors(): check…
7bb8be8 
… snapdev before traversing snapshots
FransUrbo pushed a commit to FransUrbo/zfs that referenced this pull request Sep 5, 2014
@bprotopopov @FransUrbo
=> openzfs#2479: bprotopopov/zvol-scale - zvol_create_minors(): check…
7bf72aa 
… snapdev before traversing snapshots
FransUrbo pushed a commit to FransUrbo/zfs that referenced this pull request Sep 5, 2014
@bprotopopov @FransUrbo
=> openzfs#2479: bprotopopov/zvol-scale - zvol_create_minors(): check…
e77147c 
… snapdev before traversing snapshots
FransUrbo pushed a commit to FransUrbo/zfs that referenced this pull request Sep 7, 2014
@bprotopopov @FransUrbo
=> openzfs#2479: bprotopopov/zvol-scale - zvol_create_minors(): check…
dd353bf 
… snapdev before traversing snapshots
FransUrbo pushed a commit to FransUrbo/zfs that referenced this pull request Sep 10, 2014
@bprotopopov @FransUrbo
=> openzfs#2479: bprotopopov/zvol-scale - zvol_create_minors(): check…
29cea57 
… snapdev before traversing snapshots
FransUrbo pushed a commit to FransUrbo/zfs that referenced this pull request Sep 14, 2014
@bprotopopov @FransUrbo
=> openzfs#2479: bprotopopov/zvol-scale - zvol_create_minors(): check…
7b0330c 
… snapdev before traversing snapshots
@behlendorf behlendorf added this to the 0.6.5 milestone Feb 11, 2015
@behlendorf behlendorf added Bug - Minor Type: Performance Performance improvement or performance problem labels Feb 11, 2015
@behlendorf behlendorf modified the milestones: 0.6.5, 0.7.0 Jul 22, 2015
kernelOfTruth pushed a commit to kernelOfTruth/zfs that referenced this pull request Aug 6, 2015
@bprotopopov @kernelOfTruth
zvol_create_minors(): check snapdev before traversing snapshots
162d134 
References:
openzfs#2479
openzfs@79c76d5 (Change KM_PUSHPAGE -> KM_SLEEP)

Porting notes:
@@ __zvol_create_minor(const char *name, boolean_t ignore_snapdev)

[which got changed to]

@@ __zvol_create_minor(const char *name)

doi = kmem_alloc(sizeof (dmu_object_info_t), KM_PUSHPAGE);

[replaced with]

doi = kmem_alloc(sizeof (dmu_object_info_t), KM_SLEEP);

Caused by

79c76d5
Change KM_PUSHPAGE -> KM_SLEEP
(upstream sync)
kernelOfTruth pushed a commit to kernelOfTruth/zfs that referenced this pull request Aug 6, 2015
@bprotopopov @kernelOfTruth
zvol state locking: refinements for scalability
f04207d 
References:
openzfs#2479
openzfs@79c76d5 (Change KM_PUSHPAGE -> KM_SLEEP)

@@ __zvol_create_minor(const char *name)

    doi = kmem_alloc(sizeof (dmu_object_info_t), KM_PUSHPAGE);

    [replaced with]

    doi = kmem_alloc(sizeof (dmu_object_info_t), KM_SLEEP);

    Caused by

    79c76d5
    Change KM_PUSHPAGE -> KM_SLEEP
    (upstream sync)
@kernelOfTruth kernelOfTruth mentioned this pull request Aug 6, 2015
Closed
kernelOfTruth pushed a commit to kernelOfTruth/zfs that referenced this pull request Aug 19, 2015
@bprotopopov @kernelOfTruth
zvol_create_minors(): check snapdev before traversing snapshots
7399e4a 
References:
openzfs#2479
openzfs@79c76d5 (Change KM_PUSHPAGE -> KM_SLEEP)

Porting notes:
@@ __zvol_create_minor(const char *name, boolean_t ignore_snapdev)

[which got changed to]

@@ __zvol_create_minor(const char *name)

doi = kmem_alloc(sizeof (dmu_object_info_t), KM_PUSHPAGE);

[replaced with]

doi = kmem_alloc(sizeof (dmu_object_info_t), KM_SLEEP);

Caused by

79c76d5
Change KM_PUSHPAGE -> KM_SLEEP
(upstream sync).

Fixing "unparenthesized return expression" message in

linux 1509
kernelOfTruth pushed a commit to kernelOfTruth/zfs that referenced this pull request Aug 19, 2015
@bprotopopov @kernelOfTruth
zvol state locking: refinements for scalability
89d5a97 
References:
openzfs#2479
openzfs@79c76d5 (Change KM_PUSHPAGE -> KM_SLEEP)

@@ __zvol_create_minor(const char *name)

    doi = kmem_alloc(sizeof (dmu_object_info_t), KM_PUSHPAGE);

    [replaced with]

    doi = kmem_alloc(sizeof (dmu_object_info_t), KM_SLEEP);

    Caused by

    79c76d5
    Change KM_PUSHPAGE -> KM_SLEEP
    (upstream sync).

Fixing cstyle errors:

space or tab at end of line

indent by spaces instead of tabs

missing space between keyword and paren

unparenthesized return expression
kernelOfTruth pushed a commit to kernelOfTruth/zfs that referenced this pull request Aug 19, 2015
@bprotopopov @kernelOfTruth
zvol_create_minors(): check snapdev before traversing snapshots
4b65bb8 
References:
openzfs#2479
openzfs@79c76d5 (Change KM_PUSHPAGE -> KM_SLEEP)

Porting notes:
@@ __zvol_create_minor(const char *name, boolean_t ignore_snapdev)

[which got changed to]

@@ __zvol_create_minor(const char *name)

doi = kmem_alloc(sizeof (dmu_object_info_t), KM_PUSHPAGE);

[replaced with]

doi = kmem_alloc(sizeof (dmu_object_info_t), KM_SLEEP);

Caused by

79c76d5
Change KM_PUSHPAGE -> KM_SLEEP
(upstream sync).

Fixing cstyle error:

"unparenthesized return expression" message in

linux 1509
kernelOfTruth pushed a commit to kernelOfTruth/zfs that referenced this pull request Aug 19, 2015
@bprotopopov @kernelOfTruth
zvol state locking: refinements for scalability
54bbab4 
References:
openzfs#2479
openzfs@79c76d5 (Change KM_PUSHPAGE -> KM_SLEEP)

@@ __zvol_create_minor(const char *name)

    doi = kmem_alloc(sizeof (dmu_object_info_t), KM_PUSHPAGE);

    [replaced with]

    doi = kmem_alloc(sizeof (dmu_object_info_t), KM_SLEEP);

    Caused by

    79c76d5
    Change KM_PUSHPAGE -> KM_SLEEP
    (upstream sync).

Fixing cstyle errors:

space or tab at end of line

indent by spaces instead of tabs

missing space between keyword and paren

unparenthesized return expression
kernelOfTruth pushed a commit to kernelOfTruth/zfs that referenced this pull request Aug 19, 2015
@bprotopopov @kernelOfTruth
zvol state locking: refinements for scalability
3c1758e 
References:
openzfs#2479
openzfs@79c76d5 (Change KM_PUSHPAGE -> KM_SLEEP)

@@ __zvol_create_minor(const char *name)

    doi = kmem_alloc(sizeof (dmu_object_info_t), KM_PUSHPAGE);

    [replaced with]

    doi = kmem_alloc(sizeof (dmu_object_info_t), KM_SLEEP);

    Caused by

    79c76d5
    Change KM_PUSHPAGE -> KM_SLEEP
    (upstream sync).

Fixing cstyle errors:

space or tab at end of line

indent by spaces instead of tabs

missing space between keyword and paren

unparenthesized return expression
@behlendorf behlendorf added the Component: ZVOL ZFS Volumes label Aug 31, 2015
@bprotopopov
Copy link
Contributor Author

Closing this request as #3830 includes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: ZVOL ZFS Volumes Type: Performance Performance improvement or performance problem
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bprotopopov @behlendorf