Fix FreeBSD (incl. CI) reporting swallowing errors on reruns

[nabijaczleweli]

Motivation and Context

Turns out, when your test-suite fails with

Results Summary
PASS	 1358
FAIL	   7
SKIP	  47

Running Time:	04:00:02
Percent passed:	96.2%
Log directory:	/var/tmp/test_results/20220225T092538
mktemp: illegal option -- p
usage: mktemp [-d] [-q] [-t prefix] [-u] template ...
       mktemp [-d] [-q] [-u] -t prefix
mktemp: illegal option -- p
usage: mktemp [-d] [-q] [-t prefix] [-u] template ...
       mktemp [-d] [-q] [-u] -t prefix
/usr/local/share/zfs/zfs-tests.sh: cannot create : No such file or directory
/usr/local/share/zfs/zfs-tests.sh: cannot create : No such file or directory
/usr/local/share/zfs/zfs-tests.sh: cannot create : No such file or directory
/usr/local/share/zfs/zfs-tests.sh: cannot create : No such file or directory
/usr/local/share/zfs/zfs-tests.sh: cannot create : No such file or directory
/usr/local/share/zfs/zfs-tests.sh: cannot create : No such file or directory

and succeeds, that's a bad thing!!

Description

Make it not do that. Hopefully. I'm delirious and there's a like a war or something next door.

How Has This Been Tested?

This has driven me crazy in #12996 (comment) as I tried to bisect it on CI, so if the FreeBSD CI fails then it's good.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Performance enhancement (non-breaking change which improves efficiency)
• Code cleanup (non-breaking change which makes code smaller or more readable)
• Breaking change (fix or feature that would cause existing functionality to change)
• Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
• Documentation (a change to man pages or other documentation)

Checklist:

• My code follows the OpenZFS code style requirements.
• I have updated the documentation accordingly.
• I have read the contributing document.
• I have added tests to cover my changes. – lol
• I have run the ZFS Test Suite with this change applied. – ibid.
• All commit messages are properly formatted and contain Signed-off-by.

[nabijaczleweli]

This passes, it's all green: http://build.zfsonlinux.org/builders/FreeBSD%20stable%2F13%20amd64%20%28TEST%29/builds/3961/steps/shell_4/logs/summary, it has 7 FAILs, among them receive-o-x_props_override, which is not ignored, and is caught correctly, e.g., here: http://build.zfsonlinux.org/builders/FreeBSD%20stable%2F13%20amd64%20%28TEST%29/builds/3968/steps/shell_4/logs/summary.

I don't actually know what broke it, because, well: FreeBSD CI was unreliable at best since 2320e6e. @behlendorf it is for this reason I'd like to (modestly, it's just CI, but I cannot possibly tell you how stark raving mad this has driven me over the past however-long I've been trying to even remotely understand why #12996 is failing in stuff I haven't vaguely touched) fast-track this so we do actually catch new test failures on FreeBSD.

[behlendorf]

That's unfortunate. It seems we didn't catch this initially since the GitHub Actions builders only test Linux, and then when we enabled it 3 weeks ago for the other CI builders in openzfs/zfs-buildbot#243 we didn't notice the errors in the FreeBSD log. Let's just wait for the CI to finish with it.