Destroy legacy string functions. Clean out vtoc.h

[nabijaczleweli]

Motivation and Context

All my homies hate the legacy string functions. Also, the freebsd strings.h stub said "do not remove", which is irresistible.

Description

Draft because on top of #12901, otherwise g2g.

nabijaczleweli@tarta:~/store/code/zfs$ git grep -E 'b(cmp|copy|zero)'
config/Rules.am:AM_CPPFLAGS += -D"bcopy(...)=bcopy(__VA_ARGS__) __attribute__((deprecated(\"bcopy(3) is deprecated. Use memcpy(3)/memmove(3) instead!\")))"
config/Rules.am:AM_CPPFLAGS += -D"bcmp(...)=bcmp(__VA_ARGS__) __attribute__((deprecated(\"bcmp(3) is deprecated. Use memcmp(3) instead!\")))"
config/Rules.am:AM_CPPFLAGS += -D"bzero(...)=bzero(__VA_ARGS__) __attribute__((deprecated(\"bzero(3) is deprecated. Use memset(3) instead!\")))"
include/sys/arc.h:arc_read_done_func_t arc_bcopy_func;
module/zfs/arc.c:arc_bcopy_func(zio_t *zio, const zbookmark_phys_t *zb, const blkptr_t *bp,
scripts/cstyle.pl:      if (/!\s*(strcmp|strncmp|bcmp)\s*\(/) {
nabijaczleweli@tarta:~/store/code/zfs$ git grep -E 'b(cmp|copy|zero)' | wc
      6      41     649

down from, uh,

nabijaczleweli@tarta:~/store/code/zfs$ git grep -E 'b(cmp|copy|zero)' origin/master | wc
    898    4089   76557
nabijaczleweli@tarta:~/store/code/zfs$ git grep -E 'b(cmp|copy|zero)' origin/master | cut -d: -f2 | uniq | wc
    135     135    3746

Also, I went to town on vtoc.h. Maybe a little too to town? But I don't think any mercy should be shown.

Also also I made zpool wait -t (and all other users of getsubopt(3)) accept just the word[,...]s instead of word[=whatever][,...] (for a delightfully const moment).

How Has This Been Tested?

Builds.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Performance enhancement (non-breaking change which improves efficiency) – I mean, probably, given that most memcpys are memcpys instead of memmoves. That being said, this is really more notional I think.
• Code cleanup (non-breaking change which makes code smaller or more readable)
• Breaking change (fix or feature that would cause existing functionality to change)
• Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
• Documentation (a change to man pages or other documentation)

Checklist:

• My code follows the OpenZFS code style requirements.
• I have updated the documentation accordingly.
• I have read the contributing document.
• I have added tests to cover my changes. – none apply
• I have run the ZFS Test Suite with this change applied. – CI take my hand
• All commit messages are properly formatted and contain Signed-off-by.

[sempervictus]

Prolific, thank you :). I wonder if there are any out of tree consumers for this stuff like GRUB or what-not which may expect the symbols to be around for something. By no means suggesting to let dead code lie, just wondering out loud what weird uses the larger ecosystem may have for some of these legacy paths.
What's the appropriate translation for достопримечательность in this context anyway (given that it's bit expands to "it is" vs "belonging to it")? I'm guessing intended to convey the presence of specific semantics at those sites, though in that colloquial/inferential meaning i'm missing the nuanced "why" piece (that being why it is достойено к примечанию).

[nabijaczleweli]

VTOC is (I'm guessing from the headers here) an AT&T UNIX disk labelling system. Crookedly reproduced in Solaris. Not reproduced outside. The SYSCALL32 stuff, on the other hand, is for 32-bit-userland-on-64-bit-kernels (think i686 on and amd64 kernel, would x32 produce another, third, set of definitions? doesn't bear thinking about). Nothing uses this. I guess the error codes and (partial?) MBR(?) partition code lists may be used outside, but. Well. It's libefi. Decidedly the worst and most annoying bit of libzfs, and I'd say openzfs as it stands today (and it's for writes, which neither bootloaders nor GRUB do (well, GRUB does have a single persistent block, but, you know, it's different)). I yearn for the day when I remove it entirely. Hopefully.

Also, GRUB? You do know that GRUB doesn't (cannot) link to Solaris code because the GPL is too proprietary to be compatible with the CDDL, right? This is the primary reason it's absolute hot shit and not worth the effort to do boot pools (especially on EFI).

As for достопримечательности, it's "places worth visiting" in a touristy sense, I guess? Not necessarily sights to be seen, since those are natural sites and достопримечательности aren't necessarily. Dunno, its like a vibe, too. In lieu of a translation I recommend being slavic and speaking russian from an early age (though, indeed, that may be a little too aspirational for the casual reader).

[gmelikov]

Offtopic, an interesting and close sense of meaning is attraction in a way of place/thing.

[nabijaczleweli]

Rebased, g2g