Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

history_006_neg: Avoid piping send directly to /dev/null #12872

Merged
merged 1 commit into from
Dec 17, 2021
Merged

history_006_neg: Avoid piping send directly to /dev/null #12872

merged 1 commit into from
Dec 17, 2021

Conversation

rincebrain
Copy link
Contributor

@rincebrain rincebrain commented Dec 16, 2021 •
edited
Loading

Motivation and Context

Test failing.

Description

zfs send -i foo bar > /dev/null => zfs send -i foo bar | cat > /dev/null

How Has This Been Tested?

Not.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf behlendorf added Component: Test Suite Indicates an issue with the test framework or a test case Status: Code Review Needed Ready for review and testing labels Dec 17, 2021
@behlendorf behlendorf requested a review from jwk404 December 17, 2021 00:13
@rincebrain
Avoid piping send directly to /dev/null
fae97b0 
Unfortunately, openzfs#11445 means while we fail gracefully now, we still
fail, unless people want to implement a complex workaround just to
support /dev/null.

So let's just use the cheap workaround in a test for now.

Signed-off-by: Rich Ercolani <[email protected]>
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Dec 17, 2021
@behlendorf behlendorf merged commit 1a79f7e into openzfs:master Dec 17, 2021
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Feb 10, 2022
@rincebrain @tonyhutter
ZTS: Avoid piping send directly to /dev/null
d4794c8 
Unfortunately, openzfs#11445 means while we fail gracefully now, we still
fail, unless people want to implement a complex workaround just to
support /dev/null.

So let's just use the cheap workaround in a test for now.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: John Kennedy <[email protected]>
Signed-off-by: Rich Ercolani <[email protected]>
Closes openzfs#12872
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@rincebrain @nicman23
ZTS: Avoid piping send directly to /dev/null
f4ae7f0 
Unfortunately, openzfs#11445 means while we fail gracefully now, we still
fail, unless people want to implement a complex workaround just to
support /dev/null.

So let's just use the cheap workaround in a test for now.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: John Kennedy <[email protected]>
Signed-off-by: Rich Ercolani <[email protected]>
Closes openzfs#12872
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@rincebrain @nicman23
ZTS: Avoid piping send directly to /dev/null
ad19f01 
Unfortunately, openzfs#11445 means while we fail gracefully now, we still
fail, unless people want to implement a complex workaround just to
support /dev/null.

So let's just use the cheap workaround in a test for now.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: John Kennedy <[email protected]>
Signed-off-by: Rich Ercolani <[email protected]>
Closes openzfs#12872
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@jwk404 jwk404 jwk404 approved these changes

Assignees
No one assigned
Labels
Component: Test Suite Indicates an issue with the test framework or a test case Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rincebrain @behlendorf @jwk404