Skip to content

Commit

Permalink
ZTS: Avoid piping send directly to /dev/null
Browse files Browse the repository at this point in the history
Unfortunately, openzfs#11445 means while we fail gracefully now, we still
fail, unless people want to implement a complex workaround just to
support /dev/null.

So let's just use the cheap workaround in a test for now.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: John Kennedy <[email protected]>
Signed-off-by: Rich Ercolani <[email protected]>
Closes openzfs#12872
  • Loading branch information
rincebrain authored and nicman23 committed Aug 22, 2022
1 parent a0f621b commit ad19f01
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion tests/zfs-tests/tests/functional/history/history_006_neg.ksh
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,9 @@ if ! is_linux; then
log_must zfs share $fs
log_must zfs unshare $fs
fi
log_must zfs send -i $snap1 $snap2 > /dev/null
# https://github.com/openzfs/zfs/issues/11445
set -o pipefail
log_must zfs send -i $snap1 $snap2 | cat > /dev/null
log_must zfs holds $snap1

log_must eval "zpool history $TESTPOOL > $NEW_HISTORY"
Expand Down

0 comments on commit ad19f01

Please sign in to comment.