Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KVM Live Snapshot Support #1129

Closed
behlendorf opened this issue Dec 4, 2012 · 2 comments
Closed

KVM Live Snapshot Support #1129

behlendorf opened this issue Dec 4, 2012 · 2 comments
Labels
Type: Feature Feature request or new feature

Comments

@behlendorf
Copy link
Contributor

Integrating with this new functionality looks very doable and very cool. Someone should investigating writing the needed hooks for ZFS.

https://events.linuxfoundation.org/slides/2011/linuxcon-japan/lcj2011_sorensen.pdf
@behlendorf behlendorf mentioned this issue Dec 4, 2012
Closed
@behlendorf behlendorf removed this from the 0.7.0 milestone Oct 7, 2014
@rlaager
Copy link
Member

rlaager commented Oct 1, 2016

If you are talking about ZFS in a guest, then the required functionality is freeze/thaw, for which we have issue #260.

If you are talking about ZFS on the host, then qemu and/or libvirt need to support calling zfs snapshot, which is an issue for those projects. (There has been work in this area; libvirt supports ZFS for its storage pools, but I don't think snapshot support has been written yet.)

@rlaager rlaager closed this as completed Oct 1, 2016
@lenucksi
Copy link

lenucksi commented Oct 2, 2016

Although the ZFS integration into libvirt and especially the virt-manager does not seem to be exactly prime-time but rather experimental. See here: https://libvirt.org/storage.html#StorageBackendZFS

pcd1193182 pushed a commit to pcd1193182/zfs that referenced this issue Sep 26, 2023
@ahrens
DLPX-87473 stress.reboot.test_repeated_reboots failed with crash dump…
36ef106 
… on OCI (openzfs#1129)

The problem is the same as DLPX-87209
(https://github.com/delphix/zfs/pull/1081).  The fix for that had no
effect, because it modified the local variable `client` which is not
used.  We need to instead modify the client that has already been set in
the `clientInfo`.  Additionally, we need to disable "eventual
consistency" so that our "ShouldRetryOperation" is actually used.  This
is safe because OCI's object storage is actually fully consistent
according to the docs
(https://docs.oracle.com/en-us/iaas/Content/Object/Concepts/objectstorageoverview.htm)

Also restructure the code so that the local variable is not in scope
after it's copied to the ClientInfo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Feature Feature request or new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rlaager @behlendorf @lenucksi