Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zfs rename does not rename snapshot read only devices udev #1121

Closed
byteharmony opened this issue Dec 1, 2012 · 7 comments
Closed

zfs rename does not rename snapshot read only devices udev #1121

byteharmony opened this issue Dec 1, 2012 · 7 comments
Milestone

Comments

@byteharmony
Copy link

My test machine had rc11 (didn't get a chance to test with rc12 yet). System had a 6xx snapshots. Rename a volume did rename the snapshots in zfs, but the snapshot devices did not get renamed.

BK

@behlendorf
Copy link
Contributor

This was fixed in rc12

@byteharmony
Copy link
Author

Sorry i didn't test rc12 before posting.

Thanks,
BK

@behlendorf
Copy link
Contributor

See commit 0e20a31 , I'm closing this issue since this was addressed in what will be rc13 (this was not fixed in rc12 which is what I stated above). @byteharmony if you find you still have issues with master we can reopen it and get them resolved.

@byteharmony
Copy link
Author

AWESOME!

I was wondering if you have any ideas on 2 other fronts.

  1.   I noticed I no longer have to use write through or write back disks in KVM, I can use no cache. So your team implemented something to make that work (since rc8, that was the last time I tested that). The using no cache appears to be significantly faster and reduced the load levels on the systems running zfs zvol based kvm guests.
    
  2.   On the snapshot topic, is there anyone aware of the work redhat is doing to integrate KVM with windows VSS based snapshots. It would be the best thing ever if we could get our ZOL system snapshots to be a part of that. Even if redhat doesn’t officially support it. My experience with the redhat team as I started using commercially supported software from them (after using CentOS for a long time) has been very positive.
    

Thanks again.
BK

@behlendorf
Copy link
Contributor

  1.   I noticed I no longer have to use write through or write back disks in KVM, I can use no cache. So your team implemented something to make that work (since rc8, that was the last time I tested that). The using no cache appears to be significantly faster and reduced the load levels on the systems running zfs zvol based kvm guests.
    

We didn't fix this explicitly, but I expect the various memory management improvements since rc8 helped with this. Several other deadlocks were resolved which might of been the root cause, it's hard to say for sure without a stack trace from rc8.

  1.   On the snapshot topic, is there anyone aware of the work redhat is doing to integrate KVM with windows VSS based snapshots. It would be the best thing ever if we could get our ZOL system snapshots to be a part of that. Even if redhat doesn’t officially support it. My experience with the redhat team as I started using commercially supported software from them (after using CentOS for a long time) has been very positive.
    

Sorry, I'm not familiar with it.

@byteharmony
Copy link
Author

https://events.linuxfoundation.org/slides/2011/linuxcon-japan/lcj2011_sorensen.pdf

Here is a doc on the VSS snapshot / KVM info.

No need to figure out how / why it's fixed, if it breaks I'll let you know :)

Thanks!
BK

@behlendorf
Copy link
Contributor

@byteharmony I've opened #1129 to track the KVM feature. It looks very doable and very neat.

pcd1193182 pushed a commit to pcd1193182/zfs that referenced this issue Sep 26, 2023
…object_agent (openzfs#1121)

build(deps): bump pin-project-lite in /cmd/zfs_object_agent

Bumps [pin-project-lite](https://github.com/taiki-e/pin-project-lite) from 0.2.11 to 0.2.12.
- [Release notes](https://github.com/taiki-e/pin-project-lite/releases)
- [Changelog](https://github.com/taiki-e/pin-project-lite/blob/main/CHANGELOG.md)
- [Commits](taiki-e/pin-project-lite@v0.2.11...v0.2.12)

---
updated-dependencies:
- dependency-name: pin-project-lite
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants