Skip to content
This repository has been archived by the owner on Feb 26, 2020. It is now read-only.

Fix RWSEM_SPINLOCK_IS_RAW check failed #622

Closed
wants to merge 1 commit into from

Conversation

tuxoko
Copy link
Contributor

@tuxoko tuxoko commented Jun 19, 2017

Initialize dummy_lock to fix the build error in gcc 7.1.1 with:
error: ‘dummy_lock’ is used uninitialized in this function

Signed-off-by: Chunwei Chen [email protected]

tuxoko pushed a commit to tuxoko/zfs that referenced this pull request Jun 19, 2017
Signed-off-by: Chunwei Chen <[email protected]>
Requires-spl:refs/pull/622/head
Copy link
Contributor

@tonyhutter tonyhutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds for me on Fedora 26 (gcc 7.1.1). You'll want to split it into two lines to get around 80-char limit though.

@tuxoko
Copy link
Contributor Author

tuxoko commented Jun 22, 2017

This need to be in 0.6.5.x as it would cause build failure on that branch.

Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from the cstyle nit.

Initialize dummy_lock to fix the build error in gcc 7.1.1 with:
  error: ‘dummy_lock’ is used uninitialized in this function

Signed-off-by: Chunwei Chen <[email protected]>
@tuxoko
Copy link
Contributor Author

tuxoko commented Jun 27, 2017

Wrapped the line.

tuxoko pushed a commit to tuxoko/zfs that referenced this pull request Jun 27, 2017
Signed-off-by: Chunwei Chen <[email protected]>
Requires-spl:refs/pull/622/head
tonyhutter pushed a commit to tonyhutter/spl that referenced this pull request Jun 29, 2017
Initialize dummy_lock to fix the build error in gcc 7.1.1 with:
  error: ‘dummy_lock’ is used uninitialized in this function

Reviewed-by: Tony Hutter <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Chunwei Chen <[email protected]>
Closes openzfs#622
tonyhutter pushed a commit that referenced this pull request Jul 20, 2017
Initialize dummy_lock to fix the build error in gcc 7.1.1 with:
  error: ‘dummy_lock’ is used uninitialized in this function

Reviewed-by: Tony Hutter <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Chunwei Chen <[email protected]>
Closes #622
em-winterschon referenced this pull request in openzfs/zfs May 31, 2021
Last use of wait_lock was removed in "Linux 5.3 compat: retire
rw_tryupgrade()" (e7a99da).

Fixes the issue reported in
#11097 (comment)

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Orivej Desh <[email protected]>
Closes #11309
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants