Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete rw_semaphore.wait_lock configure check #11309

Merged
merged 1 commit into from
Dec 10, 2020
Merged

Delete rw_semaphore.wait_lock configure check #11309

merged 1 commit into from
Dec 10, 2020

Conversation

orivej
Copy link
Contributor

@orivej orivej commented Dec 8, 2020 •
edited
Loading

Motivation and Context

Last use of wait_lock was removed in "Linux 5.3 compat: retire rw_tryupgrade()" (e7a99da).

Fixes the issue reported in #11097 (comment) (Does not fix the original issue with migrate_enable.)

Description

How Has This Been Tested?

Tried to build against linux-rt, now the build passes the configure phase and breaks on #11097.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@orivej orivej mentioned this pull request Dec 8, 2020
Open
@orivej orivej changed the title Delete rw_semaphore.wait_lock test Delete rw_semaphore.wait_lock configure check Dec 8, 2020
@orivej
Delete rw_semaphore.wait_lock configure check
99e1ac0 
Last use of wait_lock was removed in "Linux 5.3 compat: retire
rw_tryupgrade()" (e7a99da).

Fixes the issue reported in
openzfs#11097 (comment)

Signed-off-by: Orivej Desh <[email protected]>
@orivej orivej force-pushed the rw_semaphore-wait_lock branch from e1e0337 to 99e1ac0 Compare December 8, 2020 02:39
@rugubara
Copy link
Contributor

rugubara commented Dec 8, 2020

I tried to apply your patch on top of the zfs-kmod-2.0.0 package in Gentoo. the patch applied cleanly, but configuration still fails with

checking whether fops->fallocate() exists... yes
checking whether zlib_deflate_workspacesize() wants 2 args... yes
checking whether struct rw_semaphore member wait_lock is raw... configure: error:
	*** None of the expected "rwsem_spinlock_is_raw" interfaces were detected.
	*** This may be because your kernel version is newer than what is
	*** supported, or you are using a patched custom kernel with
	*** incompatible modifications.
	***
	*** ZFS Version: zfs-2.0.0-r0-gentoo
	*** Compatible Kernels: 3.10 - 5.9

@orivej
Copy link
Contributor Author

orivej commented Dec 8, 2020

You are using pregenerated ./configure. Please regenerate it with ./autogen.sh.

@behlendorf behlendorf added Status: Code Review Needed Ready for review and testing Type: Building Indicates an issue related to building binaries labels Dec 8, 2020
behlendorf
behlendorf approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find. It'll be nice to shed this now unnecessary compatibility code. Even if it doesn't address the other issue.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Dec 9, 2020
@behlendorf behlendorf merged commit ab4fb9b into openzfs:master Dec 10, 2020
rugubara added a commit to rugubara/overlay that referenced this pull request Dec 22, 2020
@rugubara
zfs-kmod-2.0.0-r1.ebuild to incorporate
4c01539 
openzfs/zfs#11309 and allow
building against rt-sources
behlendorf pushed a commit that referenced this pull request Dec 23, 2020
@orivej @behlendorf
Delete rw_semaphore.wait_lock configure check
fad85e5 
Last use of wait_lock was removed in "Linux 5.3 compat: retire
rw_tryupgrade()" (e7a99da).

Fixes the issue reported in
#11097 (comment)

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Orivej Desh <[email protected]>
Closes #11309
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@orivej @jsai20
Delete rw_semaphore.wait_lock configure check
673747d 
Last use of wait_lock was removed in "Linux 5.3 compat: retire
rw_tryupgrade()" (e7a99da).

Fixes the issue reported in
openzfs#11097 (comment)

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Orivej Desh <[email protected]>
Closes openzfs#11309
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
@orivej
Delete rw_semaphore.wait_lock configure check
890e65b 
Last use of wait_lock was removed in "Linux 5.3 compat: retire
rw_tryupgrade()" (e7a99da).

Fixes the issue reported in
openzfs#11097 (comment)

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Orivej Desh <[email protected]>
Closes openzfs#11309
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested) Type: Building Indicates an issue related to building binaries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orivej @rugubara @behlendorf