[WIP] Replace print calls with logging #441
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will rebase on #440 once merged. |
motin
changed the title
englehardt
changed the title
|
We should fix #258 as part of this |
This also better handles errors if we still fail after retrying (so the aggregator process doesn't crash).
The current inter-process log handler discards `exc_info` and adds the arguments to the exception message. This prevents Sentry from properly grouping log messages by their exception and call information. We send the information if possible (or fall back to the previous approach if not).
|
Closing this since I never managed to get the tests passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is especially important in
SocketInterface.py, which is currentlyprinting important serialization errors.