Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function get_psl shoudl use logger instead of print #258

Closed
turban1988 opened this issue Feb 8, 2019 · 1 comment
Closed

Function get_psl shoudl use logger instead of print #258

turban1988 opened this issue Feb 8, 2019 · 1 comment
Labels
task Doesn't change any behaviour

Comments

@turban1988
Copy link
Contributor

Hi,
I noticed that the function get_psl() uses print statements instead of a logger.

https://github.com/mozilla/OpenWPM/blob/b3ead7e38892095950806e8bcbb2e1129c27ca96/automation/utilities/domain_utils.py#L17-L28

If desired, I can try to fix this over the weekend.
@englehardt
Copy link
Collaborator

This would be a nice change. In general we have an odd setup of having a separate logging process that serlializes writes from the other python processes as well as from the Firefox extension. That might lead to some complications in fixing this.

turban1988 added a commit to turban1988/OpenWPM that referenced this issue Feb 10, 2019
@turban1988
fixed missing logging output (Issue openwpm#258)
ed90f64
turban1988 added a commit to turban1988/OpenWPM that referenced this issue Feb 10, 2019
@turban1988
fixed missing logging output (Issue openwpm#258)
e37186d
turban1988 added a commit to turban1988/OpenWPM that referenced this issue Feb 10, 2019
@turban1988
fixed missing logging output (Issue openwpm#258)
a8837de
turban1988 added a commit to turban1988/OpenWPM that referenced this issue Feb 10, 2019
@turban1988
fixed missing logging output (Issue openwpm#258)
f28b25a
@englehardt englehardt added the task Doesn't change any behaviour label Aug 6, 2019
@englehardt englehardt mentioned this issue Aug 6, 2019
Closed
@vringar vringar closed this as completed May 7, 2020
Zaxeli pushed a commit to Zaxeli/OpenWPM that referenced this issue Aug 10, 2021
@turban1988
fixed missing logging output (Issue openwpm#258)
292290e
Zaxeli pushed a commit to Zaxeli/OpenWPM that referenced this issue Aug 10, 2021
@turban1988
fixed missing logging output (Issue openwpm#258)
a15aab1
Zaxeli pushed a commit to Zaxeli/OpenWPM that referenced this issue Aug 10, 2021
@turban1988
fixed missing logging output (Issue openwpm#258)
535df89
Zaxeli pushed a commit to Zaxeli/OpenWPM that referenced this issue Aug 10, 2021
@turban1988
fixed missing logging output (Issue openwpm#258)
dce8ff4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
task Doesn't change any behaviour
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@englehardt @vringar @turban1988