Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop multi answer fix #767

Merged
merged 7 commits into from
Jun 16, 2017
Merged

Develop multi answer fix #767

merged 7 commits into from
Jun 16, 2017

Conversation

mgage
Copy link
Member

@mgage mgage commented May 24, 2017

This branch fixes reported bugs in which only the first answer of a multiAnswer question was recorded for "sticky answers" and into the pastAnswer log. It still needs extensive testing.

mgage added 6 commits May 23, 2017 15:45
@mgage
Temporary commit — the past answer logs appear to work — but need sim…
f8b26e1 
…plification and clean up.
@mgage
Comment out warning messages
f08c38e 
and comparison between old and new ways of logging past answers
@mgage
Make sure all of the answers are printed.
9ca5ced 
Counting the number of scores gives the number of answer groups (or answer evaluators) but not the number of answers.
@mgage
Refactor create_ans_str_from_responses()
e5bd698 
Also changed the calling hierarchal structure of WeBWorK::ContentGenerator::Problem.  The previous one seemed devious.
@mgage
Update documentation
c832b2f
@mgage
Refactor: Use WeBWorK::ContentGenerator::ProblemUtil::ProblemUtil::cr…
09515e6 
…eate_ans_str_from_responses in GatewayQuiz

This is a first pass. The problems are gone through twice once to record sticky answers and a
second time to record passed answers. These could probably be combined but at the moment the order of
presentation is different.
@mgage
Copy link
Member Author

mgage commented Jun 4, 2017 •
edited
Loading

This is companion pull request to pg PR #302. It addresses bugs that occur in multiAnswer and matrix answer evaluators. Many of the bugs arose because of the change to using the answer evaluator as the primary the primary object for a given answer —rather than the answer blank. (This helps regularize the increasing number of answer evaluators that use more than one answer blank — e.g. matrices and multiAnswer. At the moment I don’t know of any answer evaluators that share an answer blank — if that comes up there are mechanisms to deal with it on a case by case basis — but no organized protocol.)

@mgage
Copy link
Member Author

mgage commented Jun 4, 2017 •
edited
Loading

bug #3003 regarding preserving matrix answers beyond the first answer is fixed. You can test on
Library/WHFreeman/Holt_linear_algebra/Chaps_1-4/3.4.58.pg. (Remember to pull pg PR #302 as well as this one.)

bug #3812 is fixed by this PR and the companion #302 for PG.
Test on: Library/FortLewis/DiffEq/3-Linear-systems/07-Repeated-eigenvalues/KJ-4-7-08-multians.pg

bug #3822 is fixed by this PR
Test on: Library/Hope/Calc1/05-02-Sigma-notation/sigma-notation-D02.pg

@mgage
Copy link
Member Author

mgage commented Jun 6, 2017 •
edited
Loading

I believe this PR is ready for extensive checking. It should be checked on questions that call multiAnswer() and check matrices. I have attached the set definition file containing the questions I used for checking for both multiAnswer.def and multiAnsQuiz. You will need to change the extension from .txt to .def before uploading it to your webwork course.
I have also included the compressed file of the directory setmultiAnswer/ which contains the questions which are not standard questions from the OPL.
setmultiAnswer.def.txt
setmultiAnsQuiz.def.txt
setmultiAnswer.tgz.txt

@Alex-Jordan
Copy link
Contributor

What is the time line for a next release? I could do extensive checking, but it might creep into July before I would be finished.

@mgage
Insure that $studentAnswer and $answerScore are defined.
f826c8d 
This eliminates error messages at the end of quizzes.  I'm not sure if this
just hides other errors or not, however initializing $answerScore=0 and $studentAnswer=''
seems safe.
@mgage
Copy link
Member Author

mgage commented Jun 6, 2017 via email

@Alex-Jordan
Copy link
Contributor

OK, PreTeXt related PR's should wait until the August merge then. They are a mess on my local branches of pg, webwork2, and mathbook. It will take me the summer to organize, commit, and test. I'll try to prioritize doing some testing here before July.

@mgage
Copy link
Member Author

mgage commented Jun 6, 2017 via email

@mgage
Copy link
Member Author

mgage commented Jun 6, 2017 •
edited
Loading

Here is a better homework test suite for multianswer questions. This one includes the files for some of the questions which were modified and stored locally rather than being taken from the OPL.

  1. Remove .txt suffix and upload to the templates directory
    setmultiAnswer.tgz.txt
    setmultiAnswer.def.txt
    setmultiAnsQuiz.def.txt

@pstaabp
Copy link
Member

pstaabp commented Jun 15, 2017 •
edited
Loading

Here's some questions/comments

  1. I imported your set above there were . There are a few missing problems: 13, 17, 18.
  2. I'm also getting errors on some of these: 3, 4, 10, 11, 12, 19,

All of the matrix questions have the problem similar to

Error in NAMED_ANS_ARRAY_EXTENSION: the answer group name should be passed in 
%options using answer_group_name=>$answer_group_name
The use of ans_label=>$answer_group_name is deprecated.
Answer blank name: MaTrIx_AnSwEr0001_1_0

  1. Some of these don't seem to have multi_answer related to them (the matrix problems and 14, 15, 16). It may be using them underneath, but it's not clear that there is multiple answer to them.

  2. Overall, the ones that are clearly multi answer seem to be working though.

@mgage
Copy link
Member Author

mgage commented Jun 15, 2017 via email

@pstaabp
Copy link
Member

pstaabp commented Jun 15, 2017

I thought I was using the pg branch too. Anyway, no errors now. I've also tested about 10 other multiAnswer problems from the library and seems to be working. If you update the missing problems (13, 17, 18) then I'll check those, but this looks good.

@mgage
Copy link
Member Author

mgage commented Jun 16, 2017

I've uploaded updated versions of the multiAnswer homework test suite. All of the question files are either standard entries in the OPL or have been placed in the templates/setmultiAnswer/ directory.
The links for uploading

  1. Remove .txt suffix and upload to the templates directory
    setmultiAnswer.tgz.txt
    setmultiAnswer.def.txt
    setmultiAnsQuiz.def.txt

@pstaabp pstaabp merged commit 72bbd73 into openwebwork:develop Jun 16, 2017
@pstaabp
Copy link
Member

pstaabp commented Jun 16, 2017

Not seeing any error with any of these problems and have done testing on others. I will pull this and the PG version in.

@mgage mgage mentioned this pull request Jun 21, 2017
Closed
19 tasks
@mgage mgage deleted the develop_multiAnswer_fix branch June 25, 2017 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpvc dpvc Awaiting requested review from dpvc

@aubreyja aubreyja Awaiting requested review from aubreyja

@pstaabp pstaabp Awaiting requested review from pstaabp

@drjt drjt Awaiting requested review from drjt

@dlglin dlglin Awaiting requested review from dlglin

@Alex-Jordan Alex-Jordan Awaiting requested review from Alex-Jordan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgage @Alex-Jordan @pstaabp