Develop multi answer fix #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NAMED_ANSWER_EXTENSION() routine needs to update the PGresponse object in the PGanswergroup. Previously,
when KEPT_ANSWERS was used, the routine calling NAMED_ANSWER_EXTENSION() had to add the extension
answer blank to the KEPT_ANSWERS queue using RECORD_FORM_LABEL. Now the routine must include a key/value
answer_group_name=>’name of answer group’ so the entire call in multiAnswer looks like:
$data->named_ans_rule_extension(
$name,$size, answer_group_name => $self->{answerName},
@_);
…ultiAnswer and matrix answer evaluators. Debugging messages have been removed
|
I believe this PR is ready for extensive checking. It should be checked on questions that call multiAnswer() and check matrices. I have attached the set definition file containing the questions I used for checking. You will need to change the extension from .txt to .def before uploading it to your webwork course. |
mgage
requested review from
dpvc,
aubreyja,
pstaabp,
drjt,
dlglin and
Alex-Jordan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is companion pull request to webwork2 PR #767. It addresses bugs that occur in multiAnswer and matrix answer evaluators. Many of the bugs arose because of the change to using the answer evaluator as the primary the primary object for a given answer —rather than the answer blank. (This helps regularize the increasing number of answer evaluators that use more than one answer blank — e.g. matrices and multiAnswer. At the moment I don’t know of any answer evaluators that share an answer blank — if that comes up there are mechanisms to deal with it on a case by case basis — but no organized protocol.)