Include the problem source hash in the problemUUID passed to PG. #2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 12, 2023
|
By the way, another advantage of this is that is avoids a potential browser caching issue with the approach in #2277. Since the problemUUID changes, the alias also changes (i.e., the link is to a completely different file). |
drgrice1
force-pushed
the
problem-uuid-includes-source-hash
branch
2 times, most recently
from
7685a47 to
ff514e2
Compare
drgrice1
force-pushed
the
problem-uuid-includes-source-hash
branch
from
ff514e2 to
c5ac981
Compare
pstaabp
approved these changes
Jan 4, 2024
drgrice1
force-pushed
the
problem-uuid-includes-source-hash
branch
from
c5ac981 to
ce4be2a
Compare
drgrice1
force-pushed
the
problem-uuid-includes-source-hash
branch
from
ce4be2a to
3f33fc6
Compare
If a problem is rendered using any of the source hash parameters (`problemSource`, `rawProblemSource`, or `uriEncodedProblemSource`), then an MD5 hex of the utf8 encoded source is added tot he problemUUID that is passed to PG. This means that if a problem is rendered by source and the source changes, then dynamically generated images will be regenerated. The PG problem editor uses the rawProblemSource, so this means that if the code for a problem changes in the code mirror window, then dynamic images will be regenerated. This replaces openwebwork#2277 and openwebwork/pg#983. This is better as it reliably detects code changes, and it does not need a change to PG. Thanks @drdrew42 for pointing this out.
drgrice1
force-pushed
the
problem-uuid-includes-source-hash
branch
from
3f33fc6 to
2b6600a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a problem is rendered using any of the source hash parameters (
problemSource,rawProblemSource, oruriEncodedProblemSource), then an MD5 hex of the utf8 encoded source is added tot he problemUUID that is passed to PG.This means that if a problem is rendered by source and the source changes, then dynamically generated images will be regenerated. The PG problem editor uses the rawProblemSource, so this means that if the code for a problem changes in the code mirror window, then dynamic images will be regenerated.
This replaces #2277 and openwebwork/pg#983. This is better as it reliably detects code changes, and it does not need a change to PG. Thanks @drdrew42 for pointing this out.