Make the PG problem editor always regenerate dynamic images. #2277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if a problem that uses dynamically generated images is edited and the code for generated an image changes the image is not regenerated unless you force it by adding `$refreshCachedImages = 1` to the problem itself. This is problematic as an author may forget to remove that later which can cause unneeded image regeneration in production use. The problem editor now forces image generation by setting `refreshCachedImages` in the PG environment. For this to work a minor change is needed to PG.
drgrice1
added a commit
to drgrice1/webwork2
that referenced
this pull request
Dec 12, 2023
If a problem is rendered using any of the source hash parameters (`problemSource`, `rawProblemSource`, or `uriEncodedProblemSource`), then an MD5 hex of the utf8 encoded source is added tot he problemUUID that is passed to PG. This means that if a problem is rendered by source and the source changes, then dynamically generated images will be regenerated. The PG problem editor uses the rawProblemSource, so this means that if the code for a problem changes in the code mirror window, then dynamic images will be regenerated. This replaces openwebwork#2277 and openwebwork/pg#983. This is better as it reliably detects code changes, and it does not need a change to PG. Thanks @drdrew42 for pointing this out.
|
Closing in favor of #2283. |
drgrice1
added a commit
to drgrice1/webwork2
that referenced
this pull request
Dec 12, 2023
If a problem is rendered using any of the source hash parameters (`problemSource`, `rawProblemSource`, or `uriEncodedProblemSource`), then an MD5 hex of the utf8 encoded source is added tot he problemUUID that is passed to PG. This means that if a problem is rendered by source and the source changes, then dynamically generated images will be regenerated. The PG problem editor uses the rawProblemSource, so this means that if the code for a problem changes in the code mirror window, then dynamic images will be regenerated. This replaces openwebwork#2277 and openwebwork/pg#983. This is better as it reliably detects code changes, and it does not need a change to PG. Thanks @drdrew42 for pointing this out.
drgrice1
added a commit
to drgrice1/webwork2
that referenced
this pull request
Dec 12, 2023
If a problem is rendered using any of the source hash parameters (`problemSource`, `rawProblemSource`, or `uriEncodedProblemSource`), then an MD5 hex of the utf8 encoded source is added tot he problemUUID that is passed to PG. This means that if a problem is rendered by source and the source changes, then dynamically generated images will be regenerated. The PG problem editor uses the rawProblemSource, so this means that if the code for a problem changes in the code mirror window, then dynamic images will be regenerated. This replaces openwebwork#2277 and openwebwork/pg#983. This is better as it reliably detects code changes, and it does not need a change to PG. Thanks @drdrew42 for pointing this out.
drgrice1
added a commit
to drgrice1/webwork2
that referenced
this pull request
Dec 17, 2023
If a problem is rendered using any of the source hash parameters (`problemSource`, `rawProblemSource`, or `uriEncodedProblemSource`), then an MD5 hex of the utf8 encoded source is added tot he problemUUID that is passed to PG. This means that if a problem is rendered by source and the source changes, then dynamically generated images will be regenerated. The PG problem editor uses the rawProblemSource, so this means that if the code for a problem changes in the code mirror window, then dynamic images will be regenerated. This replaces openwebwork#2277 and openwebwork/pg#983. This is better as it reliably detects code changes, and it does not need a change to PG. Thanks @drdrew42 for pointing this out.
drgrice1
added a commit
to drgrice1/webwork2
that referenced
this pull request
Jan 6, 2024
If a problem is rendered using any of the source hash parameters (`problemSource`, `rawProblemSource`, or `uriEncodedProblemSource`), then an MD5 hex of the utf8 encoded source is added tot he problemUUID that is passed to PG. This means that if a problem is rendered by source and the source changes, then dynamically generated images will be regenerated. The PG problem editor uses the rawProblemSource, so this means that if the code for a problem changes in the code mirror window, then dynamic images will be regenerated. This replaces openwebwork#2277 and openwebwork/pg#983. This is better as it reliably detects code changes, and it does not need a change to PG. Thanks @drdrew42 for pointing this out.
drgrice1
added a commit
to drgrice1/webwork2
that referenced
this pull request
Jan 16, 2024
If a problem is rendered using any of the source hash parameters (`problemSource`, `rawProblemSource`, or `uriEncodedProblemSource`), then an MD5 hex of the utf8 encoded source is added tot he problemUUID that is passed to PG. This means that if a problem is rendered by source and the source changes, then dynamically generated images will be regenerated. The PG problem editor uses the rawProblemSource, so this means that if the code for a problem changes in the code mirror window, then dynamic images will be regenerated. This replaces openwebwork#2277 and openwebwork/pg#983. This is better as it reliably detects code changes, and it does not need a change to PG. Thanks @drdrew42 for pointing this out.
drgrice1
added a commit
to drgrice1/webwork2
that referenced
this pull request
Jan 16, 2024
If a problem is rendered using any of the source hash parameters (`problemSource`, `rawProblemSource`, or `uriEncodedProblemSource`), then an MD5 hex of the utf8 encoded source is added tot he problemUUID that is passed to PG. This means that if a problem is rendered by source and the source changes, then dynamically generated images will be regenerated. The PG problem editor uses the rawProblemSource, so this means that if the code for a problem changes in the code mirror window, then dynamic images will be regenerated. This replaces openwebwork#2277 and openwebwork/pg#983. This is better as it reliably detects code changes, and it does not need a change to PG. Thanks @drdrew42 for pointing this out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a problem that uses dynamically generated images is edited and the code for generated an image changes the image is not regenerated unless you force it by adding
$refreshCachedImages = 1to the problem itself. This is problematic as an author may forget to remove that later which can cause unneeded image regeneration in production use.The problem editor now forces image generation by setting
refreshCachedImagesin the PG environment. For this to work a minor change is needed to PG. See openwebwork/pg#983.