Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove usage of const enum #888

Merged

Conversation

TimoGlastra
Copy link
Contributor

Fixes #884, see the issue for why we can't use const enums

@TimoGlastra TimoGlastra requested a review from a team as a code owner June 20, 2022 08:07
@berendsliedrecht berendsliedrecht enabled auto-merge (squash) June 20, 2022 08:15
@berendsliedrecht
Copy link
Contributor

Interesting, never knew about this. Is there maybe an eslint rule to disable constant enums?

auto-merge was automatically disabled June 20, 2022 08:15

Pull request was closed

@berendsliedrecht berendsliedrecht enabled auto-merge (squash) June 20, 2022 08:15
Signed-off-by: Timo Glastra <[email protected]>
@TimoGlastra
Copy link
Contributor Author

Added an eslint rule to disallow const enums

Copy link
Contributor

@morrieinmaas morrieinmaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2022

Codecov Report

Merging #888 (452c1d6) into main (8d67e63) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #888   +/-   ##
=======================================
  Coverage   87.57%   87.57%           
=======================================
  Files         463      463           
  Lines       11083    11083           
  Branches     1745     1745           
=======================================
  Hits         9706     9706           
  Misses       1377     1377           
Impacted Files Coverage Δ
...nnections/errors/DidExchangeProblemReportReason.ts 100.00% <100.00%> (ø)
.../src/modules/connections/models/DidExchangeRole.ts 100.00% <100.00%> (ø)
...src/modules/connections/models/DidExchangeState.ts 100.00% <100.00%> (ø)
...rc/modules/connections/models/HandshakeProtocol.ts 100.00% <100.00%> (ø)
...ages/core/src/modules/dids/methods/peer/didPeer.ts 93.75% <100.00%> (ø)
...kages/core/src/modules/oob/domain/OutOfBandRole.ts 100.00% <100.00%> (ø)
...ages/core/src/modules/oob/domain/OutOfBandState.ts 100.00% <100.00%> (ø)
...rc/storage/migration/updates/0.1-0.2/credential.ts 100.00% <100.00%> (ø)
packages/core/src/types.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d67e63...452c1d6. Read the comment docs.

@berendsliedrecht berendsliedrecht merged commit a7754bd into openwallet-foundation:main Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

const enums can't be used after code is transpiled
4 participants