-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove usage of const enum #888
fix: remove usage of const enum #888
Conversation
Signed-off-by: Timo Glastra <[email protected]>
Interesting, never knew about this. Is there maybe an eslint rule to disable constant enums? |
Signed-off-by: Timo Glastra <[email protected]>
Added an eslint rule to disallow const enums |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov Report
@@ Coverage Diff @@
## main #888 +/- ##
=======================================
Coverage 87.57% 87.57%
=======================================
Files 463 463
Lines 11083 11083
Branches 1745 1745
=======================================
Hits 9706 9706
Misses 1377 1377
Continue to review full report at Codecov.
|
Fixes #884, see the issue for why we can't use const enums