fix: remove usage of const enum (#888)

Signed-off-by: Timo Glastra <[email protected]>
openwallet-foundation · Jun 20, 2022 · a7754bd · a7754bd
1 parent 521d489
commit a7754bd
Show file tree

Hide file tree

Showing 10 changed files with 19 additions and 9 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -57,6 +57,16 @@ module.exports = {
         patterns: ['packages/*'],
       },
     ],
+    // Do not allow const enums
+    // https://github.com/typescript-eslint/typescript-eslint/issues/561#issuecomment-593059472
+    // https://ncjamieson.com/dont-export-const-enums/
+    'no-restricted-syntax': [
+      'error',
+      {
+        selector: 'TSEnumDeclaration[const=true]',
+        message: "Don't declare const enums",
+      },
+    ],
   },
   overrides: [
     {

diff --git a/packages/core/src/modules/connections/errors/DidExchangeProblemReportReason.ts b/packages/core/src/modules/connections/errors/DidExchangeProblemReportReason.ts
@@ -3,7 +3,7 @@
  *
  * @see https://github.com/hyperledger/aries-rfcs/blob/main/features/0023-did-exchange/README.md#errors
  */
-export const enum DidExchangeProblemReportReason {
+export enum DidExchangeProblemReportReason {
   RequestNotAccepted = 'request_not_accepted',
   RequestProcessingError = 'request_processing_error',
   ResponseNotAccepted = 'response_not_accepted',

diff --git a/packages/core/src/modules/connections/models/DidExchangeRole.ts b/packages/core/src/modules/connections/models/DidExchangeRole.ts
@@ -1,4 +1,4 @@
-export const enum DidExchangeRole {
+export enum DidExchangeRole {
   Requester = 'requester',
   Responder = 'responder',
 }
diff --git a/packages/core/src/modules/connections/models/DidExchangeState.ts b/packages/core/src/modules/connections/models/DidExchangeState.ts
@@ -3,7 +3,7 @@
  *
  * @see https://github.com/hyperledger/aries-rfcs/blob/main/features/0023-did-exchange/README.md#state-machine-tables
  */
-export const enum DidExchangeState {
+export enum DidExchangeState {
   Start = 'start',
   InvitationSent = 'invitation-sent',
   InvitationReceived = 'invitation-received',

diff --git a/packages/core/src/modules/connections/models/HandshakeProtocol.ts b/packages/core/src/modules/connections/models/HandshakeProtocol.ts
@@ -1,4 +1,4 @@
-export const enum HandshakeProtocol {
+export enum HandshakeProtocol {
   Connections = 'https://didcomm.org/connections/1.0',
   DidExchange = 'https://didcomm.org/didexchange/1.0',
 }
diff --git a/packages/core/src/modules/dids/methods/peer/didPeer.ts b/packages/core/src/modules/dids/methods/peer/didPeer.ts
@@ -8,7 +8,7 @@ export function isValidPeerDid(did: string): boolean {
   return isValid
 }
 
-export const enum PeerDidNumAlgo {
+export enum PeerDidNumAlgo {
   InceptionKeyWithoutDoc = 0,
   GenesisDoc = 1,
   MultipleInceptionKeyWithoutDoc = 2,

diff --git a/packages/core/src/modules/oob/domain/OutOfBandRole.ts b/packages/core/src/modules/oob/domain/OutOfBandRole.ts
@@ -1,4 +1,4 @@
-export const enum OutOfBandRole {
+export enum OutOfBandRole {
   Sender = 'sender',
   Receiver = 'receiver',
 }
diff --git a/packages/core/src/modules/oob/domain/OutOfBandState.ts b/packages/core/src/modules/oob/domain/OutOfBandState.ts
@@ -1,4 +1,4 @@
-export const enum OutOfBandState {
+export enum OutOfBandState {
   Initial = 'initial',
   AwaitResponse = 'await-response',
   PrepareResponse = 'prepare-response',

diff --git a/packages/core/src/storage/migration/updates/0.1-0.2/credential.ts b/packages/core/src/storage/migration/updates/0.1-0.2/credential.ts
@@ -39,7 +39,7 @@ export async function migrateCredentialRecordToV0_2(agent: Agent) {
   }
 }
 
-export const enum CredentialRole {
+export enum CredentialRole {
   Issuer,
   Holder,
 }

diff --git a/packages/core/src/types.ts b/packages/core/src/types.ts
@@ -9,7 +9,7 @@ import type { OutOfBandRecord } from './modules/oob/repository'
 import type { AutoAcceptProof } from './modules/proofs'
 import type { MediatorPickupStrategy } from './modules/routing'
 
-export const enum KeyDerivationMethod {
+export enum KeyDerivationMethod {
   /** default value in indy-sdk. Will be used when no value is provided */
   Argon2IMod = 'ARGON2I_MOD',
   /** less secure, but faster */
-Original file line number
+Diff line change
@@ Expand Up @@
       }
     }
-    export const enum CredentialRole {
+    export enum CredentialRole {
       Issuer,
       Holder,
     }
@@ Expand Down @@