Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: anoncreds w3c migration metadata #1803

Conversation

auer-martin
Copy link
Contributor

No description provided.

@auer-martin auer-martin force-pushed the fix/anoncreds-w3c-migration-meta branch from 0684eca to 30e6b5b Compare March 27, 2024 10:05
Comment on lines +99 to +101
for (const [key, meta] of Object.entries(legacyRecord.metadata.data)) {
w3cCredentialRecord.metadata.set(key, meta)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any metadata that can clash? I.e. metadata fields on the W3C record? Or do we set those after so it should be good?

Or are there any metadata fields that were on anoncreds record, but not needed anymore on the w3c record (the ones we created with _anoncreds and _internal prefixes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the new w3c-anoncreds metadata is set afterward, so that should not be a problem.

I did a quick check for metadata but could not find anything.

@auer-martin auer-martin marked this pull request as ready for review March 27, 2024 11:18
@TimoGlastra TimoGlastra merged commit 069c9c4 into openwallet-foundation:main Mar 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate record metadata when migrating from AnonCredsCredentialRecord to W3CCredentialRecord
2 participants