Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate record metadata when migrating from AnonCredsCredentialRecord to W3CCredentialRecord #1801

Closed
genaris opened this issue Mar 26, 2024 · 2 comments · Fixed by #1803
Closed

Comments

@genaris
Copy link
Contributor

genaris commented Mar 26, 2024

Please correct me if I'm wrong but as far as I could see/test, if it happened to me to have an AFJ 0.4.2 wallet whose AnonCredsCredentialRecord include custom metadata (set by the controller, not the internal ones set by the framework), when upgrading to Credo 0.5.0 I'll lose any custom metadata for them, since the newly generated records do not take it into account.

If this is the case, I think we should fix it because otherwise we'll complicate (or even block) the migration path for existing apps that might have been relying on that feature for their records.

@TimoGlastra
Copy link
Contributor

Good catch, yes we should fix that

@TimoGlastra
Copy link
Contributor

@auer-martin is going to take a look at this

@TimoGlastra TimoGlastra linked a pull request Mar 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants