-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android): React Native 0.76.x support #22
fix(android): React Native 0.76.x support #22
Conversation
Signed-off-by: Berend Sliedrecht <[email protected]>
@@ -41,12 +41,12 @@ | |||
}, | |||
"devDependencies": { | |||
"react": "18.2.0", | |||
"react-native": "0.74.1", | |||
"react-native": "*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this reflect the tested/dev version of react native? I think it is currently resolving to 0.76.6
. I don't think this is a blocker. but I think *
might get inadvertently updated to an unexpected major/minor version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated it to the same as the peerdep, >= 0.71
. I prefer to be optimistic here and to say that 0.77 and 0.78, etc. will be supported from a version perspective. Otherwise you'll get a bit too annoying messages from npm
that warn you that it might not work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!! What made you figure it out in the end?
I think in the end it was that two react natives were installed (0.74 and 0.76) and it would choose one for the app and one for the lib. Quite an annoying issue to debug haha. |
Signed-off-by: Berend Sliedrecht <[email protected]>
6b5244d
to
45ee96f
Compare
closes #16 and openwallet-foundation/askar#324