Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): React Native 0.76.x support #22

Merged

Conversation

berendsliedrecht
Copy link
Contributor

@berendsliedrecht berendsliedrecht commented Jan 24, 2025

closes #16 and openwallet-foundation/askar#324

  • Works with RN up to 76, old and new arch (no codegen yet)
  • Should work with everything from rn 71 and up
  • Tested with rn 74,75 and 76 (new and old arch)

Signed-off-by: Berend Sliedrecht <[email protected]>
@berendsliedrecht berendsliedrecht requested a review from a team as a code owner January 24, 2025 17:29
@berendsliedrecht berendsliedrecht changed the title android rn 76 fix(android): React Native 0.76.x support Jan 24, 2025
@@ -41,12 +41,12 @@
},
"devDependencies": {
"react": "18.2.0",
"react-native": "0.74.1",
"react-native": "*",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this reflect the tested/dev version of react native? I think it is currently resolving to 0.76.6. I don't think this is a blocker. but I think * might get inadvertently updated to an unexpected major/minor version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated it to the same as the peerdep, >= 0.71. I prefer to be optimistic here and to say that 0.77 and 0.78, etc. will be supported from a version perspective. Otherwise you'll get a bit too annoying messages from npm that warn you that it might not work.

Copy link
Contributor

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!! What made you figure it out in the end?

@berendsliedrecht
Copy link
Contributor Author

Very nice!! What made you figure it out in the end?

I think in the end it was that two react natives were installed (0.74 and 0.76) and it would choose one for the app and one for the lib. Quite an annoying issue to debug haha.

Signed-off-by: Berend Sliedrecht <[email protected]>
@berendsliedrecht berendsliedrecht merged commit 7bd35a3 into openwallet-foundation:main Jan 27, 2025
4 checks passed
@berendsliedrecht berendsliedrecht deleted the android-rn-76 branch January 27, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Android wrapper work with RN 0.76+
3 participants