-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Android wrapper work with RN 0.76+ #16
Comments
Some more detail: Branch that is the closest to getting it working (https://github.com/berendsliedrecht/askar-wrapper-javascript/tree/rn-76). The issue is, is that when we want to link the askar library as a shared object to the native module (happening in the CMakeLists.txt), it somehow messes up the registration of the PlatformConstants module from React Native. When the library is removed, it all compiles and runs good, but when the library is added it compiles, but it does not run (immediate error). Related RN issue: facebook/react-native#47352
|
Thanks for the detail @berendsliedrecht — that helps. @cvarjao — FYI |
RN 0.76 has the new architecture enabled by default, would it work with using RN 0.76 but still using "old architecture"? Regardless, I think we should work towards supporting the new architecture in the near future as that is the direction RN is going |
No it does not work by disabling the new architecture. Supporting the new architecture would be nice, but I would like to wait for it to be more stable. As soon as we can add a shared object without issues, we can try it. It will take quite some time as we would have to restructure the entire wrapper (which ends up being better then, so thats good). |
See #15 for context around the issue. PR's are very welcome!
The text was updated successfully, but these errors were encountered: