Restore changes from #289 #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dation#289 and openwallet-foundation#288 Signed-off-by: Emiliano Suñé <[email protected]>
Signed-off-by: Emiliano Suñé <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #299 +/- ##
==========================================
+ Coverage 87.12% 87.12% +<.01%
==========================================
Files 232 232
Lines 10816 10817 +1
==========================================
+ Hits 9423 9424 +1
Misses 1393 1393 |
|
Looks good |
nrempel
approved these changes
Dec 10, 2019
|
This pull request fixes 1 alert when merging e19d173 into 1ea9041 - view on LGTM.com fixed alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore changes lost during conflict resolution between #288 and #289
@nrempel can you please check and confirm everything is there?