Add create-proposal endpoint to the present-proof API namespace #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes in this PR depend on this aca-py pull request. |
Codecov Report
@@ Coverage Diff @@
## master #288 +/- ##
==========================================
+ Coverage 81.61% 81.64% +0.02%
==========================================
Files 232 232
Lines 10770 10785 +15
==========================================
+ Hits 8790 8805 +15
Misses 1980 1980 |
Signed-off-by: Emiliano Suñé <[email protected]>
esune
force-pushed
the
create-request
branch
from
86fd001 to
98184e2
Compare
andrewwhitehead
approved these changes
Nov 30, 2019
esune
added a commit
to esune/acapy
that referenced
this pull request
Dec 10, 2019
…dation#289 and openwallet-foundation#288 Signed-off-by: Emiliano Suñé <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new API endpoint
/present-proof/create-requestto support creating a Proof request without needing an active connection with an agent, as previously supported by the deprecated endpoint/presentation_exchange/create_request.tests have been added following the ones that were already available for
presentation_exchange_send_free_requestand removing the test cases that are not required due to the missingconnection-idrequirement.Please note my formatter has made changes to the files I edited (currently using black version
19.3b0): let me know if this is expected, or what I should be doing to have a formatter behaviour that is consistent with the rest of the community.Tagging @andrewwhitehead for review.