-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2289 Migrate to Poetry #2436
#2289 Migrate to Poetry #2436
Conversation
Signed-off-by: Gavin <[email protected]>
Signed-off-by: Gavin <[email protected]>
Signed-off-by: Gavin <[email protected]>
I believe we want to install the dependencies for
|
Signed-off-by: Gavin <[email protected]>
Signed-off-by: Gavin <[email protected]>
Signed-off-by: Gavin <[email protected]>
ef48b81
to
d1baab1
Compare
Signed-off-by: Gavin <[email protected]>
Signed-off-by: Gavin <[email protected]>
Signed-off-by: Gavin <[email protected]>
Signed-off-by: Gavin <[email protected]>
Signed-off-by: Gavin <[email protected]>
Signed-off-by: Gavin <[email protected]>
Signed-off-by: Gavin <[email protected]>
Signed-off-by: Gavin <[email protected]>
Signed-off-by: Gavin <[email protected]>
Signed-off-by: Gavin <[email protected]>
Signed-off-by: Gavin <[email protected]>
Signed-off-by: Gavin <[email protected]>
Signed-off-by: Gavin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great - awesome job.
Can we add a Poetry.md file in the root of the project that provides a cheat sheet for developers that have not used poetry before? Particularly around virtual envs and usage for running tasks through poetry or not using virtual envs. Also, should explain where and how poetry is used to build and publish the library.
Signed-off-by: Gavin <[email protected]>
Signed-off-by: Gavin <[email protected]>
Signed-off-by: Gavin <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
pinging @dbluhm for a final approval. |
@Gavinok -- a question for you about this PR. We discovered that the problem with the Aries Agent Test Harness that was triggered by this PR was the removal of the "bin/aca-py" shell script. From scanning the commits, it looks like that was done deliberately, but I wanted to confirm that, and the rationale for the change. It is a breaking change we'll need to document in the changelog in case anyone (like AATH) is using the file. Do you think it would be a bad thing to put the file back or in changing to poetry should it be removed? I see these two commits where the change was made:
Thanks! |
This may be a misunderstanding on my part of what poetry did with its scripts functionality. We should be able to add the original script back into the repository. The idea was that the [tool.poetry.scripts] entry in the pyproject.toml would replace it once installed. |
OK — could you do a quick and dirty PR to add it back? If it is safe enough, let’s just put it back and not have to explain it to someone. It was tougher than it should have been to find in AATH. |
Sure thing, I can't say with 100% confidence that it will work in all cases but clearly the current solution isn't helping filling it's place |
This PR resolves #2289
I migrated the use of requirements.txt and setup.py over to poetry. The use of multiple requirements.*.txt is replaced with dependency groups in the
pyproject.toml
. I have also added a dedicated[tool.poetry.group.test.dependencies]
as opposed to the original requirements.dev.txt which contained both developer dependencies and testing dependencies.