-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition ACA-Py to use poetry #2289
Comments
I like poetry, particularly for development I prefer it for dependency management. I would not be opposed to bringing it into ACA-Py. I'm not sure how the various requirements files (askar, bbs, indy, dev) would work. With poetry, i assume they would be in dependency groups, but a developer without poetry (or who does not want to use it) can't leverage those groups through Maybe a few things to prove out, but certainly onboard with supporting poetry. |
The askar, bbs, and indy requirements I think would make sense as an "extra;" these behave like pip extras and enable the user to install them using commands like |
when this work is tackled, can we do our best to update dependencies? I recently (using acapy 0.8.2) had issues doing plugin updates where packaging was in conflict with (i think black?) and i also had to specify an explicit version for typing-extensions to resolve. i know we can't possibly know all of what is out there, but it would be nice if we could reduce the potential for conflicts. |
@usingtechnology absolutely; I agree that this is sorely needed. We've run into similar issues. |
Added high priority label; I think updating dependencies is becoming increasingly urgent and having this in place would be helpful. |
Assigned to Gavin |
@usingtechnology to assit @Gavinok with PR test issues |
With #2247, we're now running on Python 3.9 and there are a number of dependency updates that I'm planning to make. This could be a good opportunity to make some improvements to our dependency management.
I am personally a fan of poetry -- it's dependency resolution is superior to pip's and it's got several nice-to-haves like builtin virtual environment handling and build and publish commands. There are still some limitations; it doesn't support platform specific builds and bundling binaries so it is unsuitable for projects like Askar right now but I think ACA-Py fits well into poetry's strengths. Externally, this transition should be seamless for ACA-Py users, whether they're consuming ACA-Py via PyPI or container image.
I'm content with our current
setup.py
andrequirements.*
files but my team has been pleased with poetry in our projects over the past couple of years.Thoughts?
@swcurran @usingtechnology @ianco @TimoGlastra
https://python-poetry.org/
The text was updated successfully, but these errors were encountered: