Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update anoncreds-rs to v0.1.0 #2283

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Update anoncreds-rs to v0.1.0 #2283

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f84c649
Update anoncreds-rs to v0.1.0
usingtechnology Jun 27, 2023
9b3070e
remove the unnecessary curl command for fetching binary (it's include…
usingtechnology Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker/Dockerfile.indy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ RUN pip3 install --no-cache-dir \
-r requirements.bbs.txt \
-r requirements.dev.txt \
-r requirements.anoncreds.txt
RUN curl -sL https://github.com/Indicio-tech/anoncreds-rs/releases/download/v0.1.0-dev.9/library-linux-x86_64.tar.gz | tar -xz -C /usr/local/lib/python3.9/site-packages/anoncreds/
RUN curl -sL https://github.com/hyperledger/anoncreds-rs/releases/download/v0.1.0/library-linux-x86_64.tar.gz | tar -xz -C /usr/local/lib/python3.9/site-packages/anoncreds/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing that we now have a build on PyPI that includes bundled binaries (as of June 2; I had missed that until now 🙂), this separate step for retrieving the binary is no longer necessary and can be removed from each of the Dockerfiles

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that answers a question I was going to pose later. Will remove those commands.


ADD --chown=indy:root . .
USER indy
Expand Down
3 changes: 1 addition & 2 deletions docker/Dockerfile.run
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,13 @@ RUN pip3 install --no-cache-dir \
-r requirements.bbs.txt \
-r requirements.dev.txt \
-r requirements.anoncreds.txt
RUN curl -sL https://github.com/hyperledger/anoncreds-rs/releases/download/v0.1.0-dev.15/library-linux-x86_64.tar.gz | tar -xz -C /usr/local/lib/python3.9/site-packages/anoncreds/
RUN curl -sL https://github.com/hyperledger/anoncreds-rs/releases/download/v0.1.0/library-linux-x86_64.tar.gz | tar -xz -C /usr/local/lib/python3.9/site-packages/anoncreds/

RUN mkdir aries_cloudagent && touch aries_cloudagent/__init__.py
ADD aries_cloudagent/version.py aries_cloudagent/version.py
ADD bin ./bin
ADD README.md ./
ADD setup.py ./
ADD healthcheck.py ./

RUN pip3 install --no-cache-dir -e .

Expand Down
2 changes: 1 addition & 1 deletion docker/Dockerfile.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ RUN pip3 install --no-cache-dir \
-r requirements.bbs.txt \
-r requirements.dev.txt \
-r requirements.anoncreds.txt
RUN curl -sL https://github.com/Indicio-tech/anoncreds-rs/releases/download/v0.1.0-dev.9/library-linux-x86_64.tar.gz | tar -xz -C /usr/local/lib/python3.9/site-packages/anoncreds/
RUN curl -sL https://github.com/hyperledger/anoncreds-rs/releases/download/v0.1.0/library-linux-x86_64.tar.gz | tar -xz -C /usr/local/lib/python3.9/site-packages/anoncreds/

ADD . .

Expand Down
2 changes: 1 addition & 1 deletion requirements.anoncreds.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
anoncreds@git+https://github.com/hyperledger/anoncreds-rs@3eca56d#subdirectory=wrappers/python
anoncreds==0.1.0