Update anoncreds-rs to v0.1.0 #2283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Sherman <[email protected]>
dbluhm
reviewed
Jun 27, 2023
docker/Dockerfile.indy
Outdated
| @@ -197,7 +197,7 @@ RUN pip3 install --no-cache-dir \ | |||
| -r requirements.bbs.txt \ | |||
| -r requirements.dev.txt \ | |||
| -r requirements.anoncreds.txt | |||
| RUN curl -sL https://github.com/Indicio-tech/anoncreds-rs/releases/download/v0.1.0-dev.9/library-linux-x86_64.tar.gz | tar -xz -C /usr/local/lib/python3.9/site-packages/anoncreds/ | |||
| RUN curl -sL https://github.com/hyperledger/anoncreds-rs/releases/download/v0.1.0/library-linux-x86_64.tar.gz | tar -xz -C /usr/local/lib/python3.9/site-packages/anoncreds/ | |||
There was a problem hiding this comment.
Seeing that we now have a build on PyPI that includes bundled binaries (as of June 2; I had missed that until now 🙂), this separate step for retrieving the binary is no longer necessary and can be removed from each of the Dockerfiles
There was a problem hiding this comment.
Thanks, that answers a question I was going to pose later. Will remove those commands.
…d in the v0.1.0 lib) Signed-off-by: Jason Sherman <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
dbluhm
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updating references to the anoncreds lib to use the v0.1.0 release.