-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/endpoint attrib structure #1934
Fix/endpoint attrib structure #1934
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1934 +/- ##
==========================================
- Coverage 93.59% 93.59% -0.01%
==========================================
Files 539 539
Lines 34262 34279 +17
==========================================
+ Hits 32069 32084 +15
- Misses 2193 2195 +2 |
Looks like an integration test is failing -- could you please take a look. We have had some intermittent ones, but I think (hope) the last of those were recently fixed. |
We're getting a failure on circleci that I haven't seen before:
I'll try triggering an update on the branch and hope that resolves it. |
Well, shoot. That didn't do it. Are these possibly related to the issues we saw in #1933? |
Signed-off-by: Char Howland <[email protected]>
Signed-off-by: Char Howland <[email protected]>
Signed-off-by: Char Howland <[email protected]>
Signed-off-by: Char Howland <[email protected]>
6be8a3b
to
eef10d4
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@dbluhm take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now!
This PR implements the solution discussed in #1928 to resolve an issue with the endpoint attrib structure. We have brought the structure into alignment with the did:sov specification by removing the nested endpoint structure and ensuring that service types
profile
andlinked_domains
can be used. This solution is interoperable with AFJ, which also supports endpoint attrib data in the following manner: