Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/endpoint attrib structure #1934

Merged

Conversation

cjhowland
Copy link
Contributor

This PR implements the solution discussed in #1928 to resolve an issue with the endpoint attrib structure. We have brought the structure into alignment with the did:sov specification by removing the nested endpoint structure and ensuring that service types profile and linked_domains can be used. This solution is interoperable with AFJ, which also supports endpoint attrib data in the following manner:

{
  "endpoint": "https://example.com",
  "types": ["did-communication", ...],
  "routingKeys": [...],
  "profile": "https://example.com/profile",
  "linked_domains": "https://example.com/linked-domains",
}

@swcurran swcurran requested review from dbluhm and ianco September 8, 2022 23:34
dbluhm
dbluhm previously approved these changes Sep 8, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2022

Codecov Report

Merging #1934 (6be8a3b) into main (4e5ed0f) will decrease coverage by 0.00%.
The diff coverage is 95.83%.

❗ Current head 6be8a3b differs from pull request most recent head eef10d4. Consider uploading reports for the commit eef10d4 to get more accurate results

@@            Coverage Diff             @@
##             main    #1934      +/-   ##
==========================================
- Coverage   93.59%   93.59%   -0.01%     
==========================================
  Files         539      539              
  Lines       34262    34279      +17     
==========================================
+ Hits        32069    32084      +15     
- Misses       2193     2195       +2     

@swcurran
Copy link
Contributor

swcurran commented Sep 9, 2022

Looks like an integration test is failing -- could you please take a look. We have had some intermittent ones, but I think (hope) the last of those were recently fixed.

@dbluhm
Copy link
Contributor

dbluhm commented Sep 9, 2022

We're getting a failure on circleci that I haven't seen before:

Either git or ssh (required by git to clone through SSH) is not installed in the image. Falling back to CircleCI's native git client but the behavior may be different from official git. If this is an issue, please use an image that has official git and ssh installed.
Cloning git repository

error cloning repository: ssh: handshake failed: ssh: unable to authenticate, attempted methods [none publickey], no supported methods remain

I'll try triggering an update on the branch and hope that resolves it.

@dbluhm
Copy link
Contributor

dbluhm commented Sep 9, 2022

Well, shoot. That didn't do it. Are these possibly related to the issues we saw in #1933?

@ryjones ryjones force-pushed the fix/endpoint-attrib-structure branch from 6be8a3b to eef10d4 Compare September 9, 2022 22:47
@ryjones ryjones enabled auto-merge (rebase) September 9, 2022 22:51
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ryjones
Copy link
Contributor

ryjones commented Sep 9, 2022

@dbluhm take a look?

@ryjones ryjones merged commit 981cc6d into openwallet-foundation:main Sep 9, 2022
Copy link
Contributor

@dbluhm dbluhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants