Feature/0.7.4 ssl public did #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emoved Signed-off-by: Char Howland <[email protected]> fix: remove layer of endpoint nesting Signed-off-by: Char Howland <[email protected]> fix: endpoint attrib json object with one top level key "endpoint" Signed-off-by: Char Howland <[email protected]>
Signed-off-by: Char Howland <[email protected]>
Signed-off-by: Char Howland <[email protected]> fix: flake8 failure Signed-off-by: Char Howland <[email protected]> fix: flake8 Signed-off-by: Char Howland <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports the endpoint attrib structure fix in PR openwallet-foundation#1934. It implements the solution discussed in openwallet-foundation#1928 to resolve an issue with the endpoint attrib structure. We have brought the structure into alignment with the did:sov specification by removing the nested endpoint structure and ensuring that service types
profileandlinked_domainscan be used. This solution is interoperable with AFJ, which also supports endpoint attrib data in the following manner:{ "endpoint": "https://example.com", "types": ["did-communication", ...], "routingKeys": [...], "profile": "https://example.com/profile", "linked_domains": "https://example.com/linked-domains", }