Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pluggable DID Resolver Interface (cleaned) #1070

Conversation

dbluhm
Copy link
Contributor

@dbluhm dbluhm commented Apr 7, 2021

This PR cleans up #1033. The change set was too large to really reason about so I've isolated changes to just the addition of the resolver and will follow up with further integration.

This PR adds interfaces to enable plugging in one or more DID resolvers. This enables ACA-Py to resolve DIDs from any VDR as long as there is a resolver plugin supporting it and the plugin is registered. By using a plugin that connects to a universal resolver instance, ACA-Py can inherit support for all methods supported by the universal resolver (with security and trust implications as a result of DIDs being resolved remotely).

dbluhm and others added 30 commits April 7, 2021 09:57
Signed-off-by: Daniel Bluhm <[email protected]>
And add a few helper methods to DID and DIDUrl

Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Adam Burdett <[email protected]>
Signed-off-by: Adam Burdett <[email protected]>
Signed-off-by: Adam Burdett <[email protected]>
Signed-off-by: Adam Burdett <[email protected]>
Signed-off-by: Adam Burdett <[email protected]>
Until this method becomes a clear need.

Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Adam Burdett <[email protected]>
dbluhm and others added 18 commits April 7, 2021 10:46
Signed-off-by: Adam Burdett <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Luis Gomez <[email protected]>
Signed-off-by: Adam Burdett <[email protected]>
Signed-off-by: Adam Burdett <[email protected]>
Signed-off-by: Luis Gomez <[email protected]>
Signed-off-by: Luis Gomez <[email protected]>
update pydid version

Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
Copy link
Contributor Author

dbluhm commented Apr 7, 2021

I thought maybe we could host both these things under a root did directory. So the resolver directory will be part of that.

aries_cloudagent/
  did/
    resolver/
      other_resolver_stuff.py
    did_key.py

OR I could host the DIDKey class in the resolver directory.

To @TimoGlastra's previous comment, I think moving to the did package will make sense

Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
Copy link
Contributor Author

dbluhm commented Apr 7, 2021

Worth noting that this PR sidesteps potential conflicts with #1056.

@andrewwhitehead
Copy link
Contributor

Looks good to me, but I can't update the branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants